Merge branch 'master' into refit-tree-manual

.ci/check-python-dists.sh

@@ -8,7 +8,7 @@ DIST_DIR=${1}
 METHOD=${METHOD:-""}
 TASK=${TASK:-""}
 
-echo "checking Python package distributions in '${DIST_DIR}'"
+echo "checking Python-package distributions in '${DIST_DIR}'"
 
 pip install \
     -qq \
@@ -55,4 +55,4 @@ else
     echo "skipping pydistcheck (does not support Python 3.${PY_MINOR_VER})"
 fi
 
-echo "done checking Python package distributions"
+echo "done checking Python-package distributions"

.ci/conda-envs/ci-core-py38.txt

@@ -41,6 +41,7 @@ bokeh=3.1.*
 fsspec=2024.5.*
 msgpack-python=1.0.*
 pluggy=1.5.*
+pyparsing=3.1.4
 pytz=2024.1
 setuptools=69.5.*
 snappy=1.2.*

.ci/conda-envs/ci-core.txt

@@ -23,7 +23,7 @@ joblib>=1.3.2
 matplotlib-base>=3.7.3
 numpy>=1.24.4
 pandas>2.0
-pyarrow>=6.0
+pyarrow-core>=6.0
 python-graphviz>=0.20.3
 scikit-learn>=1.3.2
 scipy>=1.1

.ci/install-opencl.ps1

@@ -4,31 +4,37 @@ $installer = "AMD-APP-SDKInstaller-v3.0.130.135-GA-windows-F-x64.exe"
 
 Write-Output "Downloading OpenCL platform installer"
 $ProgressPreference = "SilentlyContinue"  # progress bar bug extremely slows down download speed
-Invoke-WebRequest -OutFile "$installer" -Uri "https://github.com/microsoft/LightGBM/releases/download/v2.0.12/$installer"
+$params = @{
+    OutFile = "$installer"
+    Uri = "https://github.com/microsoft/LightGBM/releases/download/v2.0.12/$installer"
+}
+Invoke-WebRequest @params
 
 if (Test-Path "$installer") {
-  Write-Output "Successfully downloaded OpenCL platform installer"
+    Write-Output "Successfully downloaded OpenCL platform installer"
 } else {
-  Write-Output "Unable to download OpenCL platform installer"
-  Write-Output "Setting EXIT"
-  $host.SetShouldExit(-1)
-  exit 1
+    Write-Output "Unable to download OpenCL platform installer"
+    Write-Output "Setting EXIT"
+    $host.SetShouldExit(-1)
+    exit 1
 }
 
 # Install OpenCL platform from installer executable
 Write-Output "Running OpenCL installer"
-Invoke-Command -ScriptBlock { Start-Process "$installer" -ArgumentList '/S /V"/quiet /norestart /passive /log opencl.log"' -Wait }
+Invoke-Command -ScriptBlock {
+    Start-Process "$installer" -ArgumentList '/S /V"/quiet /norestart /passive /log opencl.log"' -Wait
+}
 
 $property = Get-ItemProperty -Path Registry::HKEY_LOCAL_MACHINE\SOFTWARE\Khronos\OpenCL\Vendors
-if ($property -eq $null) {
-  Write-Output "Unable to install OpenCL CPU platform"
-  Write-Output "OpenCL installation log:"
-  Get-Content "opencl.log"
-  Write-Output "Setting EXIT"
-  $host.SetShouldExit(-1)
-  exit 1
+if ($null -eq $property) {
+    Write-Output "Unable to install OpenCL CPU platform"
+    Write-Output "OpenCL installation log:"
+    Get-Content "opencl.log"
+    Write-Output "Setting EXIT"
+    $host.SetShouldExit(-1)
+    exit 1
 } else {
-  Write-Output "Successfully installed OpenCL CPU platform"
-  Write-Output "Current OpenCL drivers:"
-  Write-Output $property
+    Write-Output "Successfully installed OpenCL CPU platform"
+    Write-Output "Current OpenCL drivers:"
+    Write-Output $property
 }

.ci/lint-js.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+
+set -e -E -u -o pipefail
+
+biome ci --config-path=./biome.json --diagnostic-level=info --error-on-warnings ./

.ci/lint-powershell.ps1

@@ -0,0 +1,56 @@
+$settings = @{
+    Severity = @(
+        'Information',
+        'Warning',
+        'Error'
+    )
+    IncludeDefaultRules = $true
+    # Additional rules that are disabled by default
+    Rules = @{
+        PSAvoidExclaimOperator = @{
+            Enable = $true
+        }
+        PSAvoidLongLines = @{
+            Enable = $true
+            MaximumLineLength = 120
+        }
+        PSAvoidSemicolonsAsLineTerminators = @{
+            Enable = $true
+        }
+        PSPlaceCloseBrace = @{
+            Enable = $true
+            NoEmptyLineBefore = $true
+            IgnoreOneLineBlock = $true
+            NewLineAfter = $false
+        }
+        PSPlaceOpenBrace = @{
+            Enable = $true
+            OnSameLine = $true
+            NewLineAfter = $true
+            IgnoreOneLineBlock = $true
+        }
+        PSUseConsistentIndentation = @{
+            Enable = $true
+            IndentationSize = 4
+            PipelineIndentation = 'IncreaseIndentationAfterEveryPipeline'
+            Kind = 'space'
+        }
+        PSUseConsistentWhitespace = @{
+            Enable = $true
+            CheckInnerBrace = $true
+            CheckOpenBrace = $true
+            CheckOpenParen = $true
+            CheckOperator = $true
+            CheckSeparator = $true
+            CheckPipe = $true
+            CheckPipeForRedundantWhitespace = $true
+            CheckParameter = $true
+            IgnoreAssignmentOperatorInsideHashTable = $false
+        }
+        PSUseCorrectCasing = @{
+            Enable = $true
+        }
+    }
+}
+
+Invoke-ScriptAnalyzer -Path ./ -Recurse -EnableExit -Settings $settings

.ci/lint-r-code.R

@@ -1,4 +1,3 @@
-
 loadNamespace("lintr")
 
 args <- commandArgs(

.ci/setup.sh

@@ -29,7 +29,7 @@ if [[ $OS_NAME == "macos" ]]; then
         brew install swig
     fi
 else  # Linux
-    if type -f apt 2>&1 > /dev/null; then
+    if type -f apt > /dev/null 2>&1; then
         sudo apt-get update
         sudo apt-get install --no-install-recommends -y \
             ca-certificates \
@@ -42,10 +42,10 @@ else  # Linux
     fi
     CMAKE_VERSION="3.30.0"
     curl -O -L \
-        https://github.com/Kitware/CMake/releases/download/v${CMAKE_VERSION}/cmake-${CMAKE_VERSION}-linux-${ARCH}.sh \
+        "https://github.com/Kitware/CMake/releases/download/v${CMAKE_VERSION}/cmake-${CMAKE_VERSION}-linux-${ARCH}.sh" \
     || exit 1
     sudo mkdir /opt/cmake || exit 1
-    sudo sh cmake-${CMAKE_VERSION}-linux-${ARCH}.sh --skip-license --prefix=/opt/cmake || exit 1
+    sudo sh "cmake-${CMAKE_VERSION}-linux-${ARCH}.sh" --skip-license --prefix=/opt/cmake || exit 1
     sudo ln -sf /opt/cmake/bin/cmake /usr/local/bin/cmake || exit 1
 
     if [[ $IN_UBUNTU_BASE_CONTAINER == "true" ]]; then
@@ -142,13 +142,13 @@ else  # Linux
     fi
 fi
 
-if [[ "${TASK}" != "r-package" ]] && [[ "${TASK}" != "r-rchk" ]]; then
+if [[ "${TASK}" != "r-package" ]]; then
     if [[ $SETUP_CONDA != "false" ]]; then
         curl \
             -sL \
             -o miniforge.sh \
-            https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-$(uname)-${ARCH}.sh
-        sh miniforge.sh -b -p $CONDA
+            "https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-$(uname)-${ARCH}.sh"
+        sh miniforge.sh -b -p "${CONDA}"
     fi
     conda config --set always_yes yes --set changeps1 no
     conda update -q -y conda

.ci/test-python-oldest.sh

@@ -15,7 +15,7 @@ pip install \
   'numpy==1.19.0' \
   'pandas==1.1.3' \
   'pyarrow==6.0.1' \
-  'scikit-learn==0.24.0' \
+  'scikit-learn==0.24.2' \
   'scipy==1.6.0' \
 || exit 1
 echo "done installing lightgbm's dependencies"
@@ -30,7 +30,7 @@ pip freeze
 echo ""
 echo "checking that examples run without error"
 
-# run a few examples to test that Python package minimally works
+# run a few examples to test that Python-package minimally works
 echo ""
 echo "--- advanced_example.py ---"
 echo ""