Skip to content

Commit

Permalink
[ci] prevent Python tests from leaving behind files (#6626)
Browse files Browse the repository at this point in the history
Co-authored-by: James Lamb <[email protected]>
  • Loading branch information
vnherdeiro and jameslamb authored Sep 3, 2024
1 parent 15ac2f7 commit d515039
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
4 changes: 2 additions & 2 deletions tests/python_package_test/test_dask.py
Original file line number Diff line number Diff line change
Expand Up @@ -1527,11 +1527,11 @@ def test_predict_with_raw_score(task, output, cluster):
assert_eq(raw_predictions, pred_proba_raw)


def test_distributed_quantized_training(cluster):
def test_distributed_quantized_training(tmp_path, cluster):
with Client(cluster) as client:
X, y, w, _, dX, dy, dw, _ = _create_data(objective="regression", output="array")

np.savetxt("data_dask.csv", np.hstack([np.array([y]).T, X]), fmt="%f,%f,%f,%f,%f")
np.savetxt(tmp_path / "data_dask.csv", np.hstack([np.array([y]).T, X]), fmt="%f,%f,%f,%f,%f")

params = {
"boosting_type": "gbdt",
Expand Down
9 changes: 6 additions & 3 deletions tests/python_package_test/test_plotting.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def test_plot_tree(breast_cancer_split):


@pytest.mark.skipif(not GRAPHVIZ_INSTALLED, reason="graphviz is not installed")
def test_create_tree_digraph(breast_cancer_split):
def test_create_tree_digraph(tmp_path, breast_cancer_split):
X_train, _, y_train, _ = breast_cancer_split

constraints = [-1, 1] * int(X_train.shape[1] / 2)
Expand All @@ -193,6 +193,7 @@ def test_create_tree_digraph(breast_cancer_split):
show_info=["split_gain", "internal_value", "internal_weight"],
name="Tree4",
node_attr={"color": "red"},
directory=tmp_path,
)
graph.render(view=False)
assert isinstance(graph, graphviz.Digraph)
Expand All @@ -213,7 +214,7 @@ def test_create_tree_digraph(breast_cancer_split):


@pytest.mark.skipif(not GRAPHVIZ_INSTALLED, reason="graphviz is not installed")
def test_tree_with_categories_below_max_category_values():
def test_tree_with_categories_below_max_category_values(tmp_path):
X_train, y_train = _categorical_data(2, 10)
params = {
"n_estimators": 10,
Expand All @@ -238,6 +239,7 @@ def test_tree_with_categories_below_max_category_values():
name="Tree4",
node_attr={"color": "red"},
max_category_values=10,
directory=tmp_path,
)
graph.render(view=False)
assert isinstance(graph, graphviz.Digraph)
Expand All @@ -257,7 +259,7 @@ def test_tree_with_categories_below_max_category_values():


@pytest.mark.skipif(not GRAPHVIZ_INSTALLED, reason="graphviz is not installed")
def test_tree_with_categories_above_max_category_values():
def test_tree_with_categories_above_max_category_values(tmp_path):
X_train, y_train = _categorical_data(20, 30)
params = {
"n_estimators": 10,
Expand All @@ -282,6 +284,7 @@ def test_tree_with_categories_above_max_category_values():
name="Tree4",
node_attr={"color": "red"},
max_category_values=4,
directory=tmp_path,
)
graph.render(view=False)
assert isinstance(graph, graphviz.Digraph)
Expand Down

0 comments on commit d515039

Please sign in to comment.