-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R README installation instruction hierarchy #3320
Comments
Hi @lorenzwalthert , thanks for raising this and for using This README has grown quite large, you're definitely right. We've tried to preserve prior section headings as much as possible, so that old links people have bookmarked or posted in stack overflow answers still work. The CRAN maintainers are taking a much-deserved break right now (https://cran.r-project.org/), but when they're back on August 24 we'll be submitting again, and I think that we have a very good chance of being accepted this time. Our challenge is that the All that said....I think moving all the installation options to a vignette all by itself is a great idea! To preserve backwards compatibility with old links, I think we'd leave all the same headings in the README but have them to point to a new installation vignette on our pkgdown site. Maybe as a part of #1944 Could you propose a sequence of headings that you think would be easier to navigate? |
Thanks @jameslamb. I did not think of back-linking 🙃.
If you want to preserve all these links, that sounds reasonable. Or thinking about which headers were there a long time already and can't be removed, while some more recent ones are probably not back-linked as much. I don't know if you can change the hierarchy of the header with preserving linking, but as I said above, you have
(no idea if that's entirely correct but this kind of information would be useful for people who don't have a clue about different compiler and built tool chains). Then, people like me would be shied away and head back to the save place further up in the REAME and choose the CRAN source installation 😄. |
oooooo I see. Ok so basically after the
|
Yes. For me, it's clear that the first two ### headers are alternative methods for installation (because the follow the pattern "installation..." in their title) but the third header does not really fit in this pattern, so such an explanation could definitively help. |
ok makes sense, thank you! I'll take a shot at re-writing it and will ask for your feedback on the PR. I hope that a week from now, I can tell you we're on CRAN 😎 |
@lorenzwalthert Thanks again for using Could you please take a look at the PR I just opened (#3360 ) and let me know what you think? Basically I've proposed reorganizing it like this: |
…3320) (#3360) * [R-package] [docs] Reorganize installation instructions (fixes #3320) * more changes * remove ability to use precompiled lib_lightgbm * remove language about installing from the CRAN section * move installation stuff * Apply suggestions from code review Co-authored-by: Nikita Titov <[email protected]> * fix anchor Co-authored-by: Nikita Titov <[email protected]>
This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
The README in
master/R-package
has a title hierarchy that is a bit confusing to me. Here I summarized the part of it that I find hard to follow:I am excited about recent efforts to distribute this package via CRAN, so maybe this README is WIP anyways and the issue is redunant. Also, since it's quite a long README and contains some information for maintainers and not end users, maybe it's worth considering to move some of this content to vignettes. In any case, thanks for this package.
The text was updated successfully, but these errors were encountered: