-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] Remove ability to install precompiled lib_lightgbm (fixes #3320) #3360
Conversation
Looks good overall. One minor thing: I think the distinction between CPU and GPU packages is very important and hence one could mention that the CRAN package and pre-compiled binaries don't support GPU training (If I got that right). One can figure that out from the header on how to build a GPU accelerated version, but explicit is better than implicit often. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments.
Co-authored-by: Nikita Titov <[email protected]>
thanks @lorenzwalthert . I disagree with this. As you mentioned in #3320, the README is already hard to follow and has a lot of information. I want to make this as simple as possible. I think anyone arriving at this page looking to build for the GPU will be drawn to "Installing a GPU-enabled Build" in the list of options. |
I just merged |
I just merged |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This PR has two changes that I couldn't see a clean way to separate, so I've combined them:
lib_lightgbm.so
with the R packageI think that the use of a precompiled
lib_lightgbm.so
in the R package has been broken for a while: #1730, #2714 . This was a valuable option before we started linking to R when building the library (added in #2901 ) and you could just downloadlib_lightgbm.so
from the releases page. Now, it is really difficult to manually build a library that works well with the R package.I think we should eliminate documentation and code about using a pre-built
lib_lightgbm
, and focus on making customizations you can't get with the CRAN package easier via #2441 (like I recommended in #3354 (comment))current README
proposal