[R] add reset_data in lgb.cv #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
commented
Nov 25, 2018
R-package/R/lgb.cv.R
Outdated
| @@ -303,7 +305,9 @@ lgb.cv <- function(params = list(), | |||
| if (env$met_early_stop) break | |||
|
|
|||
| } | |||
|
|
|||
| if (free_boosters) { | |||
| cv_booster$boosters = NULL | |||
There was a problem hiding this comment.
@Laurae2 is this enough to free the memories of boosters?
There was a problem hiding this comment.
@guolinke would anyone ever NOT want to free them? I'd rather just make this new behavior and leave the function signature the same. Adding flags to the code makes it harder to maintain, in my experience.
|
@jameslamb @Laurae2 |
jameslamb
approved these changes
Nov 30, 2018
| @@ -12,6 +12,8 @@ | |||
| #' @param categorical_feature list of str or int | |||
| #' type int represents index, | |||
| #' type str represents feature names | |||
| #' @param callbacks list of callback functions | |||
| #' List of callback functions that are applied at each iteration. | |||
There was a problem hiding this comment.
how is this change related?
There was a problem hiding this comment.
I find the doc of this parameter is misning, compared with lgb.cv.
|
|
||
| if (reset_data) { | ||
| lapply(cv_booster$boosters, function(fd) { | ||
| # Store temporarily model data elsewhere |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1854