-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] for autogenerating docs #2076
Conversation
Awesome! Great addition for #2059! @nabokovas Please fix the conflict before I start the review. @guolinke I suppose this PR should be merged after #2059, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nabokovas Thanks for your huge work!
I left some comments about Dataset
API below.
Also please use the same description for the handle
param across the file: either Handle of dataset
or An instance of dataset
.
@StrikerRUS yeah, I will take a look for #2059 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nabokovas Below is the second round of the review.
Also, please use either File name
or Filename
in descriptions across this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another couple of comments:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nabokovas Here is the last part of review.
Also, please replace @
symbols back to canonical \
ones. This should reduce PR's diff significantly and \
are already used all over the project.
@StrikerRUS maybe you can fix these minor issues directly and then this PR could be merged. |
@guolinke Sure, I think I can take this PR over in case of author's further inactivity. |
ping @nabokovas |
I am sorry for the really long delay |
@nabokovas No problem! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Comments were reworked there for easier autogenerating documentation.
No changes for the functions.
No description for LGBM_NetworkInitWithFunctions.