Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][python] allow usage and compilation of 32-bit library #2188

Merged
merged 9 commits into from
Aug 17, 2019
Merged

Conversation

StrikerRUS
Copy link
Collaborator

I think this PR should be merged after 2.2.4 release.

Refer to #1129. Closed #1864.

Description of advantages of bit32 flag comparing to simple removal of exception can be found in #1864 (comment).

@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented May 23, 2019

Here is a table with results of attempts to install LightGBM with 32-bit Python.

Method Ordinary installation Installation with bit32 flag
precompile Fail Success with warning
regular Fail Success with warning
sdist Fail Success with warning
bdist Fail -

Our wheels from PyPI cannot be installed in 32-bit environment because pip is quite smart to distinguish between architectures and platforms.

@jameslamb
Copy link
Collaborator

The amount of devotion that it takes to willingly type out a markdown table just for a comment... @StrikerRUS you are an inspiration 😀

@StrikerRUS StrikerRUS requested review from chivee and wxchan as code owners July 24, 2019 13:47
@StrikerRUS
Copy link
Collaborator Author

As we decided to bump the minor version in our next release, I'm going to merge this.

@StrikerRUS StrikerRUS changed the title [DO NOT MRG][docs][python] allow usage and compilation of 32-bit library [docs][python] allow usage and compilation of 32-bit library Aug 17, 2019
@StrikerRUS StrikerRUS merged commit 686b0cc into master Aug 17, 2019
@StrikerRUS StrikerRUS deleted the bit32 branch August 17, 2019 20:02
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants