Add support for categorical features of any type #2242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@eliseygusev Hi! Thanks for your PR! The title says
Unfortunately, it's not reachable without changing underlying JSON serializer, refer to #2134 (comment). Can you please describe the intention of this PR in more details? Also, please rebase the branch and fix conflicts. |
|
Hi @eliseygusev , I am going to close this PR due to inactivity. When you find time to come back to it, please rebase to update it to current Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added auto-conversion of the user passed categorical columns to pandas.category. This solves this issue and another step towards this