fix the bug in bin with small values #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btrotta
added a commit
to btrotta/LightGBM
that referenced
this pull request
Aug 20, 2019
btrotta
added a commit
to btrotta/LightGBM
that referenced
this pull request
Aug 20, 2019
btrotta
added a commit
to btrotta/LightGBM
that referenced
this pull request
Sep 10, 2019
btrotta
added a commit
to btrotta/LightGBM
that referenced
this pull request
Sep 10, 2019
guolinke
pushed a commit
that referenced
this pull request
Sep 28, 2019
* Fix bug where small values of max_bin cause crash. * Revert "Fix bug where small values of max_bin cause crash." This reverts commit fe5c8e2. * Add functionality to force bin thresholds. * Fix style issues. * Use stable sort. * Minor style and doc fixes. * Add functionality to force bin thresholds. * Fix style issues. * Use stable sort. * Minor style and doc fixes. * Change binning behavior to be same as PR #2342. * Add functionality to force bin thresholds. * Fix style issues. * Use stable sort. * Minor style and doc fixes. * Add functionality to force bin thresholds. * Fix style issues. * Use stable sort. * Minor style and doc fixes. * Change binning behavior to be same as PR #2342. * Add functionality to force bin thresholds. * Fix style issues. * Minor style and doc fixes. * Add functionality to force bin thresholds. * Fix style issues. * Minor style and doc fixes. * Change binning behavior to be same as PR #2342. * Add functionality to force bin thresholds. * Fix style issues. * Use stable sort. * Minor style and doc fixes. * Add functionality to force bin thresholds. * Fix style issues. * Use stable sort. * Minor style and doc fixes. * Change binning behavior to be same as PR #2342. * Use different bin finding function for predefined bounds. * Fix style issues. * Minor refactoring, overload FindBinWithZeroAsOneBin. * Fix style issues. * Fix bug and add new test. * Add warning when using categorical features with forced bins. * Pass forced_upper_bounds by reference. * Pass container types by const reference. * Get categorical features using FeatureBinMapper. * Fix bug for small max_bin. * Move GetForcedBins to DatasetLoader. * Find forced bins in dataset_loader. * Minor fixes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.