[R-package] Remove lgbdl from docs until fix #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, I think so! Refer to #2843 (comment). UPD: Or |
StrikerRUS
approved these changes
Apr 29, 2020
jameslamb
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Works for me! I think doc is appropriate here. We probably broke the integration with lgbdl a long time ago (its last commit was December 2018) so this PR doesn't represent a breaking change.
| @@ -16,7 +16,7 @@ Installation | |||
|
|
|||
| You need to install git and [CMake](https://cmake.org/) first. | |||
|
|
|||
| Note: 32-bit R/Rtools is not supported. | |||
| Note: 32-bit (i386) R/Rtools is currently not supported. | |||
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the method of installing LightGBM for R changed significantly, using Laurae2/lgbdl package is now broken.
This PR removes lgbdl temporarily from the documentation until a new working replacement package is made (to avoid confusion for end users who attempt using it and see it does not work).
The replacement package is likely to be named differently as there are currently scripts relying on the package pointing to old commits for compatibility.
@StrikerRUS
docis this the right label for this PR?