-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] [docs] fix warnings in pkgdown site building #3086
Conversation
oh @StrikerRUS was |
Yeah, I removed the branch and disabled RTD builds right after merging previous PR. Sorry! Just enabled builds again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the warning has gone from build logs and lightgbm() - Train a LightGBM model
item has appeared in the R API reference.
Cool, thanks!
All recent macOS R-package builds at Travis are stuck at
Hope it is temporary problem... |
no problem! I should have asked you to keep them. |
😬 I just tried rebuilding, let's see |
OK!
Already tried 3 times with |
😬 Travis status looks fine, no ongoing incidents... https://www.traviscistatus.com/ |
Just added 89c6b3c to see if we can get better logs and identify what is breaking in the Mac R environment on Travis. I'll revert that commit before we merge this, just using it for investigation. |
... and it just passed all checks! 😄 I guess building without logs is just near 10mins. |
WOW! I wonder if this is somehow related to how we switched all |
I think it was the |
Great investigation! |
Sorry, I wasn't clear....I don't think our Mac builds are slower now because of I think that we should:
|
ac9c4ab
to
5304479
Compare
I just rebased to |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This PR fixes the warnings from the last outstanding item in this comment: #1143 (comment)
To confirm, I ran:
re-using this branch from #3072 since it's already enabled on readthedocs.