-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] [docs] replace build_r_site.R with pkgdown::build_site() #3098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Only two minor points below for discussion.
I think |
154fd0b
to
c428cb0
Compare
After pinning
I'll merge this if CI build successfully |
@StrikerRUS now that this is merged, you can disable the |
Ah, makes perfect sense! Completely missed it.
OK. Done. Thank you very much for this great simplification! |
…icrosoft#3098) * [R-package] [docs] replace build_r_site.R with pkgdown::build_site() * fix paths * fix continuation * new_process arg
…icrosoft#3098) * [R-package] [docs] replace build_r_site.R with pkgdown::build_site() * fix paths * fix continuation * new_process arg
…icrosoft#3098) * [R-package] [docs] replace build_r_site.R with pkgdown::build_site() * fix paths * fix continuation * new_process arg
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Per this conversation (#1143 (comment)), this PR removes
build_r_site.R
and replaces it with a call topkgdown::build_site(install = FALSE)
.Documentation tools like
roxygen2::roxygenize()
,pkgdown::build_site()
, anddevtools::document()
used to try to rebuild R packages and this work well with ours. But now these tools support installing once and then running their functionality without re-building. So this flow works and only builds the package one time:I tried building this on readthedocs and it looks ok!