-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Test 32-bit builds for R package #3311
Conversation
@jameslamb I think it is okay |
ok I just updated |
I'm very worried about the Travis tests I wonder if they've finally ended support for the "Legacy" Travis (.org) and we have to switch to .com? I asked Travis about this a while ago when we faced an issue with stalled builds (#2957 (comment)) At that time, they recommended moving to travis-ci.com from travis-ci.org (https://docs.travis-ci.com/user/migrate/open-source-repository-migration) |
I'm seeing this Travis issue on other projects I work on too. I've contacted Travis support. |
Don't panic! 😃 Seems everything is OK. I rerun one short job to get updates from Travis. |
@jameslamb Should we also update docs about that 32-bit is unsopported (change to that it is supported but strongly not reccomended)? https://github.com/microsoft/LightGBM/tree/master/R-package#preparation |
no I don't think so. It won't be supported for CMake installation (#3187 (comment)). https://github.com/microsoft/LightGBM/tree/master/R-package#preparation already has a lot of stuff that you have to understand, so I'd like to avoid adding additional reading for users there if it's just of the form "here is something that is technically possible but we don't recommend it". |
@jameslamb OK, fair enough! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, forgot to approve.
I was panicked haha. I'm glad it's working again! Looking forward to being scared about this again three months from now 😆 |
Have they answered anything? |
nothing yet :/ If they don't get back to me today, I'm going to tag them on Twitter 😬 |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Now that #3307 has ben merged and the R package is passing
R CMD check
for bothx64
andi386
architectures, this PR proposes testing that in our CI. Since the 32-bit build isn't enable when building with CMake (and I think we should not enable it), as of this PRR CMD check
would be run without--no-multiarch
only for CRAN builds.This PR also proposes removing the
--no-multiarch
option from the documentation for installing with{remotes}
. If we do that, I'd want to update the artifactlightgbm-3.0.0-1-r-cran.tar.gz
on release3.0.0rc
. @guolinke is that ok? Generally I think it's bad to update artifacts once they're published, but in this case since it's something very new and experimental, since its only a pre-release, and since the new artifact would't have any breaking changes, I think it's worth it to remove the need for that flag from the documentation.