Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Test 32-bit builds for R package #3311

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Conversation

jameslamb
Copy link
Collaborator

Now that #3307 has ben merged and the R package is passing R CMD check for both x64 and i386 architectures, this PR proposes testing that in our CI. Since the 32-bit build isn't enable when building with CMake (and I think we should not enable it), as of this PR R CMD check would be run without --no-multiarch only for CRAN builds.

This PR also proposes removing the --no-multiarch option from the documentation for installing with {remotes}. If we do that, I'd want to update the artifact lightgbm-3.0.0-1-r-cran.tar.gz on release 3.0.0rc. @guolinke is that ok? Generally I think it's bad to update artifacts once they're published, but in this case since it's something very new and experimental, since its only a pre-release, and since the new artifact would't have any breaking changes, I think it's worth it to remove the need for that flag from the documentation.

@guolinke
Copy link
Collaborator

@jameslamb I think it is okay

@jameslamb
Copy link
Collaborator Author

ok I just updated lightgbm_3.0.0-1-r-cran.tar.gz on the 3.0.0rc release, so this PR's docs changes will be accurate. --no-multiarch flag can be safely omitted

@jameslamb
Copy link
Collaborator Author

I'm very worried about the Travis tests

image

I wonder if they've finally ended support for the "Legacy" Travis (.org) and we have to switch to .com?

I asked Travis about this a while ago when we faced an issue with stalled builds (#2957 (comment))

At that time, they recommended moving to travis-ci.com from travis-ci.org (https://docs.travis-ci.com/user/migrate/open-source-repository-migration)

@jameslamb
Copy link
Collaborator Author

I'm seeing this Travis issue on other projects I work on too. I've contacted Travis support.

@StrikerRUS
Copy link
Collaborator

I wonder if they've finally ended support for the "Legacy" Travis (.org) and we have to switch to .com?

Don't panic! 😃 Seems everything is OK. I rerun one short job to get updates from Travis.

@StrikerRUS
Copy link
Collaborator

@jameslamb Should we also update docs about that 32-bit is unsopported (change to that it is supported but strongly not reccomended)?

https://github.com/microsoft/LightGBM/tree/master/R-package#preparation
https://github.com/microsoft/LightGBM/blob/master/docs/GPU-Windows.rst#mingw-correct-compiler-selection

@jameslamb
Copy link
Collaborator Author

@jameslamb Should we also update docs about that 32-bit is unsopported (change to that it is supported but strongly not reccomended)?

https://github.com/microsoft/LightGBM/tree/master/R-package#preparation
https://github.com/microsoft/LightGBM/blob/master/docs/GPU-Windows.rst#mingw-correct-compiler-selection

no I don't think so. It won't be supported for CMake installation (#3187 (comment)).

https://github.com/microsoft/LightGBM/tree/master/R-package#preparation already has a lot of stuff that you have to understand, so I'd like to avoid adding additional reading for users there if it's just of the form "here is something that is technically possible but we don't recommend it".

@StrikerRUS
Copy link
Collaborator

@jameslamb OK, fair enough!

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to approve.

@jameslamb
Copy link
Collaborator Author

I wonder if they've finally ended support for the "Legacy" Travis (.org) and we have to switch to .com?

Don't panic! Seems everything is OK. I rerun one short job to get updates from Travis.

I was panicked haha. I'm glad it's working again!

Looking forward to being scared about this again three months from now 😆

@jameslamb jameslamb merged commit 8662e36 into microsoft:master Aug 18, 2020
@StrikerRUS
Copy link
Collaborator

@jameslamb

I'm seeing this Travis issue on other projects I work on too. I've contacted Travis support.

Looking forward to being scared about this again three months from now 😆

Have they answered anything?

@jameslamb
Copy link
Collaborator Author

nothing yet :/

If they don't get back to me today, I'm going to tag them on Twitter 😬

@jameslamb jameslamb deleted the r/32bit-ci branch October 11, 2020 04:37
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants