Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] remove blank lines and not-really-comments from .Rbuildignore #3318

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

jameslamb
Copy link
Collaborator

I saw this really interesting discussion on the r-pkg-devel mailing list: https://stat.ethz.ch/pipermail/r-package-devel/2020q3/005894.html

Basically, the .Rbuildignore file does not support comments. Lines that start with # will be evaluated as patterns that could match a file.

It also does not skip blank lines, so having blank lines just increases the time it takes to build a package.

This PR should slightly reduce the build time for the R package, and should avoid the unlikely but not impossible case where one of the "commented" lines matches and ignores a file that should not be ignored.

Since I'm touching this file, I also took the opportunity to rearrange it so that it is in alphabetical order (ignoring non-alphanumeric characters).

@StrikerRUS
Copy link
Collaborator

Maybe blank line after cran-comments.md in #3298 caused problems?

@jameslamb
Copy link
Collaborator Author

Maybe blank line after cran-comments.md in #3298 caused problems?

ooooo maybe! now that I know the exact R code that checks .Rbuildignore, I can probably come back in a follow-up PR and populate that file correctly. Might allow us to remove some rm statements from

rm cran-comments.md
rm AUTOCONF_UBUNTU_VERSION
rm recreate-configure.sh

@jameslamb jameslamb merged commit 7d6f742 into microsoft:master Aug 19, 2020
@jameslamb jameslamb deleted the r/rbuildignore branch October 11, 2020 04:37
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants