-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] [ci] Reduce manual effort for version updates #3335
Conversation
Co-authored-by: Guolin Ke <[email protected]>
@jameslamb I think this will be included in 3.0.0 ? |
yes it should be! Sorry, should have clarified...I built the package in #3293 (comment) from this branch, so it is ok. |
Absolutely agree! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM if it is working inside a Docker.
thanks! I can confirm that it is. The diff in Now that this is automated, it will also fail builds where we update |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This is the first step towards #3283 . It does not automate creating any artifacts (#3283 (comment), #3285 (comment)), but it removes some of the manual steps needed to update the R package when the version of LightGBM is updated.
In #3071 (comment) I proposed adding a
Makefile
with amake release
recipe, but I decided not to do that in this PR because I thought it would be very thin and therefore not worth adding another file to the repo.As of this PR, the only change that will need to be made in a release PR is to regenerate
R-package/configure
, which can be done with this command if you have Docker available (documented here):I tested this with values
3.0.0
,5.2.1
and5.2.1rc
inVERSION.txt
, just to make sure it all works as expected.