Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] [ci] Reduce manual effort for version updates #3335

Merged
merged 5 commits into from
Aug 25, 2020

Conversation

jameslamb
Copy link
Collaborator

This is the first step towards #3283 . It does not automate creating any artifacts (#3283 (comment), #3285 (comment)), but it removes some of the manual steps needed to update the R package when the version of LightGBM is updated.

In #3071 (comment) I proposed adding a Makefile with a make release recipe, but I decided not to do that in this PR because I thought it would be very thin and therefore not worth adding another file to the repo.

As of this PR, the only change that will need to be made in a release PR is to regenerate R-package/configure, which can be done with this command if you have Docker available (documented here):

docker run \
    -v $(pwd):/opt/LightGBM \
    -t ubuntu:18.04 \
    /bin/bash -c "cd /opt/LightGBM && ./R-package/recreate-configure.sh"

I tested this with values 3.0.0, 5.2.1 and 5.2.1rc in VERSION.txt, just to make sure it all works as expected.

@jameslamb jameslamb requested a review from Laurae2 as a code owner August 25, 2020 00:15
@jameslamb jameslamb mentioned this pull request Aug 25, 2020
10 tasks
build_r.R Outdated Show resolved Hide resolved
@guolinke
Copy link
Collaborator

@jameslamb I think this will be included in 3.0.0 ?

@jameslamb
Copy link
Collaborator Author

yes it should be!

Sorry, should have clarified...I built the package in #3293 (comment) from this branch, so it is ok.

@StrikerRUS
Copy link
Collaborator

@jameslamb

In #3071 (comment) I proposed adding a Makefile with a make release recipe, but I decided not to do that in this PR because I thought it would be very thin and therefore not worth adding another file to the repo.

Absolutely agree!

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM if it is working inside a Docker.

R-package/recreate-configure.sh Show resolved Hide resolved
@jameslamb
Copy link
Collaborator Author

Thanks, LGTM if it is working inside a Docker.

thanks! I can confirm that it is. The diff in configure in this PR was generated with the docker run command in the README. Everything else in this PR will work outside of Docker, for example anywhere that people run build-cran-package.sh or Rscript build_r.R.

Now that this is automated, it will also fail builds where we update VERSION.txt but forget to update R-package/configure, which I think is a good thing!

@jameslamb jameslamb merged commit 5538eb8 into microsoft:master Aug 25, 2020
@jameslamb jameslamb mentioned this pull request Oct 28, 2020
@jameslamb jameslamb deleted the r/automate-releases branch February 7, 2021 03:36
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants