Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] miscellaneous changes to comply with CRAN requirements #3338

Merged
merged 50 commits into from
Oct 8, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
11bd7e7
[R-package] update DESCRIPTION per CRAN comments
jameslamb Aug 27, 2020
aa1ad24
newlines
jameslamb Aug 27, 2020
c41a947
Apply suggestions from code review
jameslamb Aug 27, 2020
e80cb54
more fixes
jameslamb Aug 28, 2020
400c35b
update Rbuildignore
jameslamb Aug 29, 2020
346766e
Merge branch 'master' into r/description-fixes
jameslamb Aug 30, 2020
6b82785
Merge branch 'master' into r/description-fixes
jameslamb Aug 30, 2020
f61e9f6
Merge branch 'master' into r/description-fixes
jameslamb Sep 2, 2020
541d2d9
more changes
jameslamb Sep 4, 2020
1d102a5
Merge branch 'master' into r/description-fixes
guolinke Sep 6, 2020
d16bafc
more changes per CRAN response
jameslamb Sep 11, 2020
4a9a6f8
add email
jameslamb Sep 11, 2020
173c7dd
run examples in CI
jameslamb Sep 11, 2020
f36b7de
Merge branch 'master' into r/description-fixes
jameslamb Sep 11, 2020
3a0de88
add newest CRAN response
jameslamb Sep 23, 2020
d18cf5c
Merge branch 'r/description-fixes' of github.com:jameslamb/LightGBM i…
jameslamb Sep 23, 2020
8b6a3a7
add Solaris patch
jameslamb Sep 24, 2020
e7eb0c4
update patch
jameslamb Sep 24, 2020
86552d2
another attempt at ifaddrs patch
jameslamb Sep 25, 2020
e1415f7
fix unnecessary comment
jameslamb Sep 25, 2020
f7f3f41
update configure
jameslamb Sep 25, 2020
a9c301a
comments
jameslamb Sep 25, 2020
a75a0e8
bump version
jameslamb Sep 25, 2020
6c37a57
tabs
jameslamb Sep 29, 2020
3aa79b4
fix address alignment, required by cran (#3415)
guolinke Sep 30, 2020
5c19296
[R-package] add new copyright holder in DESCRIPTION (#3409)
jameslamb Sep 26, 2020
1ea66bf
fixing conflicts
jameslamb Sep 30, 2020
cac7cba
[R-package] add new copyright holder in DESCRIPTION (#3409)
jameslamb Sep 26, 2020
4fbf933
trying to fix conflicts
jameslamb Sep 30, 2020
d9aa856
more fixes
jameslamb Sep 30, 2020
82bb6c7
this will work
jameslamb Sep 30, 2020
119c6f3
Merge branch 'master' into r/description-fixes
guolinke Sep 30, 2020
3515aa8
merge master
jameslamb Oct 3, 2020
d23f094
Merge branch 'r/description-fixes' of github.com:jameslamb/LightGBM i…
jameslamb Oct 3, 2020
240fbfe
update cran-comments
jameslamb Oct 3, 2020
9617f34
merge master
jameslamb Oct 4, 2020
a0443de
Merge branch 'master' into r/description-fixes
jameslamb Oct 6, 2020
c10e23d
simplify solaris, add more testing docs
jameslamb Oct 6, 2020
3595584
stuff
jameslamb Oct 6, 2020
fab1234
remove rchck docs
jameslamb Oct 6, 2020
8528853
Merge branch 'master' into r/description-fixes
jameslamb Oct 7, 2020
bc5decf
Apply suggestions from code review
jameslamb Oct 7, 2020
0ab2261
Merge branch 'r/description-fixes' of github.com:jameslamb/LightGBM i…
jameslamb Oct 7, 2020
9d9165a
remove extra use of cat()
jameslamb Oct 7, 2020
465fbc4
change solaris check
jameslamb Oct 7, 2020
988bbf2
update docs
jameslamb Oct 7, 2020
57d9879
remove testing code
jameslamb Oct 7, 2020
46f4c1f
fix warning about cleanup not having execute permissions
jameslamb Oct 7, 2020
c6ff472
fix cmake builds
jameslamb Oct 7, 2020
6c423a5
remove blank line
jameslamb Oct 8, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions R-package/DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ Authors@R: c(
person("Yachen", "Yan", role = c("ctb")),
person("James", "Lamb", email="[email protected]", role = c("aut"))
)
Description: Tree based algorithms can be improved by introducing boosting frameworks. 'LightGBM' is one such framework, and this package offers an R interface to work with it.
Description: Tree based algorithms can be improved by introducing boosting frameworks.
'LightGBM' is one such framework, based on Ke, Guolin et al. (2017).
See the paper "LightGBM: a highly efficient gradient boosting decision tree", linked below.
This package offers an R interface to work with it.
It is designed to be distributed and efficient with the following advantages:
1. Faster training speed and higher efficiency.
2. Lower memory usage.
Expand All @@ -20,7 +23,9 @@ Description: Tree based algorithms can be improved by introducing boosting frame
Comparison experiments on public datasets suggest that 'LightGBM' can outperform existing boosting frameworks on both efficiency and accuracy, with significantly lower memory consumption. In addition, parallel experiments suggest that in certain circumstances, 'LightGBM' can achieve a linear speed-up in training time by using multiple machines.
Encoding: UTF-8
License: MIT + file LICENSE
URL: https://github.com/Microsoft/LightGBM
URL:
https://github.com/Microsoft/LightGBM,
http://papers.nips.cc/paper/6907-lightgbm-a-highly-efficient-gradient-boosting-decision
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
BugReports: https://github.com/Microsoft/LightGBM/issues
NeedsCompilation: yes
Biarch: true
Expand Down
23 changes: 2 additions & 21 deletions R-package/LICENSE
Original file line number Diff line number Diff line change
@@ -1,21 +1,2 @@
The MIT License (MIT)

Copyright (c) Microsoft Corporation

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
YEAR: 2016
COPYRIGHT HOLDER: Microsoft Corporation
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
51 changes: 51 additions & 0 deletions R-package/cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,56 @@
# CRAN Submission History

## v3.0.0 - Submission 2 - (August 28, 2020)

## v3.0.0 - Submission 1 - (August 24, 2020)

NOTE: 3.0.0-1 was never released to CRAN. CRAN was on vacation August 14-24, 2020, and in that time version 3.0.0-1 (a release candidate) because 3.0.0.
jameslamb marked this conversation as resolved.
Show resolved Hide resolved

### CRAN respoonse

> Please only ship the CRAN template fior the MIT license.

> Is there some reference about the method you can add in the Description field in the form Authors (year) doi:.....?

> Please fix and resubmit.

### `R CMD check` results

* Debian: 1 NOTE

```text
* checking CRAN incoming feasibility ... NOTE
Maintainer: ‘Guolin Ke <[email protected]>’

New submission

License components with restrictions and base license permitting such:
MIT + file LICENSE
```

* Windows: 1 NOTE

```text
* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Guolin Ke <[email protected]>'

New submission

License components with restrictions and base license permitting such:
MIT + file LICENSE
```

### Maintainer Notes

Tried updating `LICENSE` file to this template:

```yaml
YEAR: 2016
COPYRIGHT HOLDER: Microsoft Corporation
```

Added a citation and link for [the main paper](http://papers.nips.cc/paper/6907-lightgbm-a-highly-efficient-gradient-boosting-decision) in `DESCRIPTION`.
jameslamb marked this conversation as resolved.
Show resolved Hide resolved

## v3.0.0-1 - Submission 3 - (August 12, 2020)

### CRAN response
Expand Down