Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix R CMD check issue 'unable to verify current time' #3341

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

jameslamb
Copy link
Collaborator

This PR skips this R CMD check check that is breaking builds

* checking for future file timestamps ... NOTE
unable to verify current time

You can see https://stat.ethz.ch/pipermail/r-package-devel/2020q3/005930.html for details. Essentially R CMD check relies on two small web services that provide a global clock, and this NOTE can show up when those services are unavailable. They are experiencing some issues this week 🙃

I think this hack is better than just bumping ALLOWED_CHECK_NOTES, as described here: #3338 (comment)

I've added this fix in #3336 and #3298 , but since it's blocking any other PRs, I thought it made sense to pull it out into its own PR we can merge quickly.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jameslamb jameslamb merged commit 0038a66 into microsoft:master Aug 29, 2020
StrikerRUS added a commit that referenced this pull request Oct 2, 2020
StrikerRUS added a commit that referenced this pull request Oct 2, 2020
jameslamb pushed a commit that referenced this pull request Oct 2, 2020
* rename R-package workflow

* Revert "[ci] fix R CMD check issue 'unable to verify current time' (#3341)"

This reverts commit 0038a66.

* Revert "Revert "[ci] fix R CMD check issue 'unable to verify current time' (#3341)""

This reverts commit e230741.
@jameslamb jameslamb deleted the fix/r-ci branch October 11, 2020 04:37
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants