Use ctypes to pass parameters (fixes #3398) #3419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to reproduce the bug from #3398 consistently on my machine with the script below (Windows, Visual Studio, Python 2.7). It always crashes on
seed=105
.I think the cause is that
LGBM_DatasetGetFeatureNames
is expecting asize_t
input forbuffer_len
but we pass a Python integer. Apparently this can cause unpredictable behavior depending on the compiler, see https://stackoverflow.com/questions/51903911/calling-c-functions-via-python-ctypes-why-does-passing-uints-to-a-function-expe