Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Remove Python 2.7 CI jobs #3572

Closed
wants to merge 1 commit into from

Conversation

jameslamb
Copy link
Collaborator

Now that v3.1.0 has been released (#3484) and marked as the final release that supports Python 2.7 (#3565), I'd like to propose removing the Python 2.7 CI jobs.

This would unblock the work to move dask-lightgbm into this project (#3515 (comment)) and could help us save some credits on Travis while we deal with the issues caused by Travis's new announcements around ending support for open source projects (#3519).

I know there are other code-level things we could do to simplify lightgbm now that Python 2.7 support is being dropped, but I think cutting out the CI jobs is valuable enough that it's worth doing as a simple, standalone pull request.

@jameslamb jameslamb requested a review from StrikerRUS November 16, 2020 22:04
@jameslamb jameslamb requested a review from Laurae2 as a code owner November 16, 2020 22:04
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't just remove sdist job. This job is very important as it emulates installation from PyPI source.

Instead, simply remove PYTHON_VERSION=2.7 part.

@StrikerRUS
Copy link
Collaborator

Also, I'd like to wait some time before actually dropping Python 2.7, because we might need to produce hotfix 3.1.1 version with Python 2.7 support.

@jameslamb
Copy link
Collaborator Author

You can't just remove sdist job. This job is very important as it emulates installation from PyPI source.

Instead, simply remove PYTHON_VERSION=2.7 part.

oh ok, does this mean that right now on master we don't have another job that emulates "installation from PyPi source" for Python 3.x?

@jameslamb
Copy link
Collaborator Author

Also, I'd like to wait some time before actually dropping Python 2.7, because we might need to produce hotfix 3.1.1 version with Python 2.7 support.

alright I can just close this for now, I guess.

@jameslamb jameslamb closed this Nov 16, 2020
@StrikerRUS
Copy link
Collaborator

oh ok, does this mean that right now on master we don't have another job that emulates "installation from PyPi source" for Python 3.x?

We have one for macOS

LightGBM/.vsts-ci.yml

Lines 81 to 82 in 0b5e60d

sdist:
TASK: sdist

@jameslamb jameslamb deleted the fix/remove-py27-ci branch February 7, 2021 03:35
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants