[R-package] construct dataset earlier in lgb.train and lgb.cv (fixes #3583) #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jameslamb
requested changes
Nov 26, 2020
There was a problem hiding this comment.
Thanks so much for your contribution!
Based on the results from tests, I think a few more changes are required.
In addition to the specific suggestions I left, can you please fix all the linting issues noted in https://travis-ci.org/github/microsoft/LightGBM/jobs/745983264?
You can replicate linting locally by running this from the root of the repo
Rscript .ci/lint_r_code.R $(pwd)
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
jameslamb
approved these changes
Dec 1, 2020
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to fix #3583 , I think this is ready to review, please let me know if there anything I've missed!