Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 3.1.1 #3611

Merged
merged 3 commits into from
Dec 8, 2020
Merged

release 3.1.1 #3611

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3229e82
release 3.1.1
jameslamb Nov 29, 2020
6f413b8
Merge branch 'master' into 3.1.1-release
jameslamb Dec 5, 2020
5b6b59c
Merge branch 'master' into 3.1.1-release
StrikerRUS Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: 3.1.0.99.{build}
version: 3.1.1.{build}

image: Visual Studio 2015
platform: x64
Expand Down
18 changes: 9 additions & 9 deletions R-package/configure
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
# Generated by GNU Autoconf 2.69 for lightgbm 3.1.0.99.
# Generated by GNU Autoconf 2.69 for lightgbm 3.1.1.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/gha run r-valgrind

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will probably take 40-60 minutes: https://github.com/microsoft/LightGBM/actions/runs/402978050

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll use this comment thread for all R-related issues so this PR doesn't pick up too many comments and we can resolve it all at once.

good news: tests are passing on Solaris and on Windows 32-bit!
bad news: there is a NOTE from R CMD CHECK that I think was introduced by the work for #3390

  • checking R code for possible problems ... NOTE
    partial argument match of 'data' to 'dataset'
    lgb.cv : : warning in getinfo(data = data, name =
    "init_score"): partial argument match of 'data' to 'dataset'
    lgb.cv : : warning in getinfo(data = data, name = "weight"):

I'll open a separate PR to fix this and to make sure we catch it in CI. Should be quick.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this NOTE in recent builds in CI: https://github.com/microsoft/LightGBM/runs/1502651682

it wasn't caught because the "CRAN incoming note" is no longer thrown now that the package is on CRAN.

https://github.com/microsoft/LightGBM/runs/1502651682

Copy link
Collaborator Author

@jameslamb jameslamb Dec 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valgrind looks happy! This is the same output we had for 3.1.0 which was accepted by CRAN.

==2062== Memcheck, a memory error detector
==2062== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==2062== Using Valgrind-3.15.0 and LibVEX; rerun with -h for copyright info
==2062== Command: /usr/local/RDvalgrind/lib/R/bin/exec/R --no-readline --vanilla -f testthat.R
==2062== 
Loading required package: R6
==2062== Conditional jump or move depends on uninitialised value(s)
==2062==    at 0x49CF138: gregexpr_Regexc (grep.c:2439)
==2062==    by 0x49D1F13: do_regexpr (grep.c:3100)
==2062==    by 0x49A0058: bcEval (eval.c:7121)
==2062==    by 0x498B67F: Rf_eval (eval.c:727)
==2062==    by 0x498E414: R_execClosure (eval.c:1895)
==2062==    by 0x498E0C7: Rf_applyClosure (eval.c:1821)
==2062==    by 0x499FC8C: bcEval (eval.c:7089)
==2062==    by 0x498B67F: Rf_eval (eval.c:727)
==2062==    by 0x498B1CB: forcePromise (eval.c:555)
==2062==    by 0x49963AB: FORCE_PROMISE (eval.c:5142)
==2062==    by 0x4996566: getvar (eval.c:5183)
==2062==    by 0x499D1A5: bcEval (eval.c:6873)
==2062==  Uninitialised value was created by a stack allocation
==2062==    at 0x49CEC37: gregexpr_Regexc (grep.c:2369)
==2062== 
==2062== 
==2062== HEAP SUMMARY:
==2062==     in use at exit: 321,320,729 bytes in 55,930 blocks
==2062==   total heap usage: 2,659,604 allocs, 2,603,674 frees, 6,003,459,320 bytes allocated
==2062== 
==2062== 336 bytes in 1 blocks are possibly lost in loss record 152 of 2,701
==2062==    at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==2062==    by 0x40149CA: allocate_dtv (dl-tls.c:286)
==2062==    by 0x40149CA: _dl_allocate_tls (dl-tls.c:532)
==2062==    by 0x5702322: allocate_stack (allocatestack.c:622)
==2062==    by 0x5702322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==2062==    by 0x56D0DDA: ??? (in /usr/lib/x86_64-linux-gnu/libgomp.so.1.0.0)
==2062==    by 0x56C88E0: GOMP_parallel (in /usr/lib/x86_64-linux-gnu/libgomp.so.1.0.0)
==2062==    by 0x1543D7C4: LGBM_DatasetCreateFromCSC (c_api.cpp:1286)
==2062==    by 0x1546BEAB: LGBM_DatasetCreateFromCSC_R (lightgbm_R.cpp:91)
==2062==    by 0x4941E2F: R_doDotCall (dotcode.c:634)
==2062==    by 0x494CCC6: do_dotcall (dotcode.c:1281)
==2062==    by 0x499FB01: bcEval (eval.c:7078)
==2062==    by 0x498B67F: Rf_eval (eval.c:727)
==2062==    by 0x498E414: R_execClosure (eval.c:1895)
==2062== 
==2062== LEAK SUMMARY:
==2062==    definitely lost: 0 bytes in 0 blocks
==2062==    indirectly lost: 0 bytes in 0 blocks
==2062==      possibly lost: 336 bytes in 1 blocks
==2062==    still reachable: 321,320,393 bytes in 55,929 blocks
==2062==                       of which reachable via heuristic:
==2062==                         newarray           : 4,264 bytes in 1 blocks
==2062==         suppressed: 0 bytes in 0 blocks
==2062== Reachable blocks (those to which a pointer was found) are not shown.
==2062== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==2062== 
==2062== For lists of detected and suppressed errors, rerun with: -s
==2062== ERROR SUMMARY: 7 errors from 2 contexts (suppressed: 0 from 0)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolinke @StrikerRUS I think this release is ready! All the PRs we wanted to get in have been merged, and the extra CRAN checks for the R package are passing.

Should I submit to CRAN?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/gha build r-artifacts

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/microsoft/LightGBM/runs/1512517160?check_suite_focus=true

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

produced this artifact: https://github.com/microsoft/LightGBM/suites/1623533888/artifacts/29854422

I'll wait to submit until @guolinke says it's ok

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just submitted to CRAN!

#
#
# Copyright (C) 1992-1996, 1998-2012 Free Software Foundation, Inc.
Expand Down Expand Up @@ -576,8 +576,8 @@ MAKEFLAGS=
# Identity of this package.
PACKAGE_NAME='lightgbm'
PACKAGE_TARNAME='lightgbm'
PACKAGE_VERSION='3.1.0.99'
PACKAGE_STRING='lightgbm 3.1.0.99'
PACKAGE_VERSION='3.1.1'
PACKAGE_STRING='lightgbm 3.1.1'
PACKAGE_BUGREPORT=''
PACKAGE_URL=''

Expand Down Expand Up @@ -1182,7 +1182,7 @@ if test "$ac_init_help" = "long"; then
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
\`configure' configures lightgbm 3.1.0.99 to adapt to many kinds of systems.
\`configure' configures lightgbm 3.1.1 to adapt to many kinds of systems.

Usage: $0 [OPTION]... [VAR=VALUE]...

Expand Down Expand Up @@ -1244,7 +1244,7 @@ fi

if test -n "$ac_init_help"; then
case $ac_init_help in
short | recursive ) echo "Configuration of lightgbm 3.1.0.99:";;
short | recursive ) echo "Configuration of lightgbm 3.1.1:";;
esac
cat <<\_ACEOF

Expand Down Expand Up @@ -1311,7 +1311,7 @@ fi
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
lightgbm configure 3.1.0.99
lightgbm configure 3.1.1
generated by GNU Autoconf 2.69

Copyright (C) 2012 Free Software Foundation, Inc.
Expand All @@ -1328,7 +1328,7 @@ cat >config.log <<_ACEOF
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.

It was created by lightgbm $as_me 3.1.0.99, which was
It was created by lightgbm $as_me 3.1.1, which was
generated by GNU Autoconf 2.69. Invocation command line was

$ $0 $@
Expand Down Expand Up @@ -2389,7 +2389,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
# report actual input values of CONFIG_FILES etc. instead of their
# values after options handling.
ac_log="
This file was extended by lightgbm $as_me 3.1.0.99, which was
This file was extended by lightgbm $as_me 3.1.1, which was
generated by GNU Autoconf 2.69. Invocation command line was

CONFIG_FILES = $CONFIG_FILES
Expand Down Expand Up @@ -2442,7 +2442,7 @@ _ACEOF
cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
ac_cs_version="\\
lightgbm config.status 3.1.0.99
lightgbm config.status 3.1.1
configured by $0, generated by GNU Autoconf 2.69,
with options \\"\$ac_cs_config\\"

Expand Down
14 changes: 14 additions & 0 deletions R-package/cran-comments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,23 @@
# CRAN Submission History

## v3.1.1 - Submission 1 - (TBD)

### CRAN response

### Maintainer Notes

Submitted a fix to 3.1.0 that skips some learning-to-rank tests on 32-bit Windows.

## v3.1.0 - Submission 1 - (November 15, 2020)

### CRAN response

Accepted to CRAN, November 18.

On November 21, found out that the CRAN's `r-oldrel-windows-ix86+x86_64` check was failing, with an issue similar to the one faced on Solaris and fixed in https://github.com/microsoft/LightGBM/pull/3534.

CRAN did not ask for a re-submission, but this was fixed in 3.1.1.

### Maintainer Notes

This package was submitted with the following information in the "optional comments" box.
Expand Down
2 changes: 1 addition & 1 deletion VERSION.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.1.0.99
3.1.1