[R-package] fix partial matching of keyword arguments in lgb.cv() (fixes #3629)

[jameslamb]

This PR fixes #3629 , and fixes the R package CI to be sure that similar issues don't arise in the future.

Also fixes #3616

For CI, I'm proposing that instead of having a limit on the NUMBER of R CMD CHECK NOTES, we just ignore very specific NOTEs that we know are not problematic for CRAN. I think that will be less susceptible to issues like #3629 and give us more confidence that CI is catching problems that would be caught by CRAN.

This is blocking release 3.1.1 (#3611)

[StrikerRUS]

Great to see that we can simplify NOTEs checking by just some exports!

I think we can now change this to simple if grep -q -R "NOTE ...", can't we?

[jameslamb]

oh sure, I can do that

[jameslamb]

while we're thinking about it, I think we should add a fix for #3616 in this PR too:

if grep -q -R "ERROR" "$LOG_FILE_NAME"; then
    echo "ERRORs have been found by R CMD check!"
    exit -1
fi

[StrikerRUS]

Thanks!

Just one minor suggestion to simplify and speedup the code for your consideration: use one grep -E "NOTE|WARNING|ERROR" ... instead of three separated ifs (and similar for PowerShell).

[jameslamb]

Thanks!

Just one minor suggestion to simplify and speedup the code for your consideration: use one grep -E "NOTE|WARNING|ERROR" ... instead of three separated ifs (and similar for PowerShell).

I like it! Added in d9ca1c4. I tested on may Mac with bash and pwsh.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.