-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Change some 'parallel learning' references to 'distributed learning' #4000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Just one comment.
@@ -21,14 +21,14 @@ LightGBM is a gradient boosting framework that uses tree based learning algorith | |||
- Faster training speed and higher efficiency. | |||
- Lower memory usage. | |||
- Better accuracy. | |||
- Support of parallel and GPU learning. | |||
- Support of parallel, distributed, and GPU learning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same change here please:
https://github.com/microsoft/LightGBM/blame/master/docs/index.rst#L20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah missed that one, thanks. Added in 7985222
…3951) * rework distributed learning page * more references * more changes * more changes * add anchors for olds links * revert changes from #4000 * fix links * more links * Apply suggestions from code review Co-authored-by: Nikita Titov <[email protected]> * Update docs/Parallel-Learning-Guide.rst Co-authored-by: Nikita Titov <[email protected]> Co-authored-by: Nikita Titov <[email protected]>
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
In #3596, we agreed to replace the terminology "parallel learning" with "distributed learning" in this project's documentation, everywhere that that phrase was used to refer to multi-machine training. It was also agreed in that issue that this change should not break any current documentation links.
I've started doing that in #3951, in preparation for adding new Dask docs (#3814).
While working on #3951, I realized that many of the places where this language needs to be changed won't break any links. These are in things like code comments and log messages.
This pull request proposes just those changes that don't break links, to hopefully reduce the size of #3951 and make it easier to review.