-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] document sanitizers #4365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this useful addition to the documentation! Please see my comments about making this copy-pastable.
@jameslamb Thanks for your review!
I thought about it a lot and couldn't find a good variant. Unfortunately, your proposal is not fully copy-pastable as well due to that |
I would prefer then to keep my suggestion but just not include like
|
TBH, I don't like this variant very much. But because I'm out of ides for more general and clear wording, I'm going to accept your suggestion. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Refer to https://xgboost.readthedocs.io/en/latest/contrib/unit_tests.html#sanitizers-detect-memory-errors-and-data-races, #3555, #4330.