Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] parallelize compilation in CMake-based builds #4525

Merged
merged 12 commits into from
Nov 10, 2021
Merged

[R-package] parallelize compilation in CMake-based builds #4525

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4ce77a0
[R-package] parallelize compilation in CMake-based builds
jameslamb Aug 15, 2021
2f10b64
Merge branch 'master' into feat/faster-r-cmake
jameslamb Nov 6, 2021
31bb22c
Apply suggestions from code review
jameslamb Nov 6, 2021
188f157
working on adding -j
jameslamb Nov 6, 2021
cb24b78
Merge branch 'master' into feat/faster-r-cmake
jameslamb Nov 7, 2021
422a30e
Merge branch 'feat/faster-r-cmake' of github.com:microsoft/LightGBM i…
jameslamb Nov 7, 2021
d4a8854
pass -j through to install.libs.R
jameslamb Nov 7, 2021
a2f5898
add docs on -j
jameslamb Nov 7, 2021
fca17c8
Merge branch 'master' into feat/faster-r-cmake
jameslamb Nov 7, 2021
8cb11aa
use -j4
jameslamb Nov 7, 2021
3d0274c
Merge branch 'master' into feat/faster-r-cmake
jameslamb Nov 8, 2021
cd20d60
Update R-package/README.md
jameslamb Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions R-package/src/install.libs.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ if (WINDOWS && use_visual_studio) {
# Prepare installation steps
cmake_args <- NULL
build_cmd <- "make"
build_args <- "_lightgbm"
build_args <- "_lightgbm -j4"
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
lib_folder <- file.path(source_dir, fsep = "/")

# add in command-line arguments
Expand Down Expand Up @@ -194,7 +194,7 @@ if (WINDOWS) {
cmake_args <- c(cmake_args, "-G", shQuote(windows_makefile_generator))
.run_shell_command("cmake", c(cmake_args, ".."), strict = FALSE)
build_cmd <- windows_build_tool
build_args <- "_lightgbm"
build_args <- "_lightgbm -j4"
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
} else {
visual_studio_succeeded <- .generate_vs_makefiles(cmake_args)
if (!isTRUE(visual_studio_succeeded)) {
Expand All @@ -203,7 +203,7 @@ if (WINDOWS) {
cmake_args <- c(cmake_args, "-G", shQuote(windows_makefile_generator))
.run_shell_command("cmake", c(cmake_args, ".."), strict = FALSE)
build_cmd <- windows_build_tool
build_args <- "_lightgbm"
build_args <- "_lightgbm -j4"
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
} else {
build_cmd <- "cmake"
build_args <- c("--build", ".", "--target", "_lightgbm", "--config", "Release")
Expand Down