update Guolin's e-mail in setup.py
#4663
Conversation
StrikerRUS
requested review from
chivee,
henry0312,
jameslamb and
shiyu1994
as code owners
python-package/setup.py
Outdated
| @@ -350,7 +350,7 @@ def run(self) -> None: | |||
| ], | |||
| }, | |||
| maintainer='Guolin Ke', | |||
| maintainer_email='guolin.ke@microsoft.com', | |||
| maintainer_email='guolin.ke@outlook.com', | |||
There was a problem hiding this comment.
Ah thanks for catching this! Sorry I didn't think of it on #4633. Thankfully it's not as critical with PyPI as it is with CRAN.
@shiyu1994 should this be changed to your name and email? My assumption is that Microsoft would prefer to have a Microsoft employee as the primary contact for these artifacts.
There was a problem hiding this comment.
Yes. Please change it to my information. Yu Shi and [email protected]. Thanks!
There was a problem hiding this comment.
Sure! Done in 1f3326c.
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Similar to fa4ecf4#diff-99c1b03acafa469ec3315aee841d2b64f122907ff1ebef7e7be5c793faf5bf0dR8.
Sorry, forgot about this field, noticed only during releasing new version at PyPI. Should have updated it during
v3.3.0release 🤦♂️