-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] only use conda-forge when installing R packages in docs builds #4767
Conversation
Sure, done! Made it hidden (accessible via a direct link only) to not confuse RTD readers with dev branches listed in the version selection widget. |
New build for this PR:
Some last builds for
|
Speedup is not so good as your local one 🙁 UPD:
By the way, it is possible to test our guesses with RTD Docker image, not with |
Oh thanks, didn't know about that!
Yeah, sad! It still seems a little bit faster (both runs from this branch are faster than the fastest of the 7 most recent runs on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change could still be helpful.
Yeah, maybe.
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
For #3946, I'm experimenting with adding
{rmarkdown}
and{knitr}
explicitly to the conda environment used in readthedocs builds (currently they are included implicitly by installing{pkgdown}
).While doing this, I've been testing locally by running the following.
From
LightGBM/docs/conf.py
Lines 267 to 277 in 1d0d746
I found that environment solves were taking a long time, and remembered that mixing the default channels and conda-forge can lead to longer solve times:
This PR proposes adding
--override-channels
to theconda create
call used to install dependencies on RTD. Perconda create --help
.In local testing, I found that adding this argument did lead to noticably faster solves. Running the
conda create
statement used in this project's RTD builds took 4m59s without that argument and 3m5s with it! Given that, I'm optimistic it'll lead to faster builds on RTD 😎how I tested timings (click me)
Notes for Reviewers
@StrikerRUS could you temporarily enable this branch at https://readthedocs.org/projects/lightgbm/versions/ so we could test?