Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] fix --no-build-vignettes option for build-cran-package.sh #4848

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

jameslamb
Copy link
Collaborator

Discovered tonight while testing things for #4813 that there was a small issue introduced in #4775.

sh build-cran-package.sh --no-build-vignettes

invalid argument '--no-build-vignettes'

This PR fixes it. This project doesn't have any CI jobs that use that option, but I tested it locally.

@jameslamb jameslamb added the fix label Dec 3, 2021
@jameslamb jameslamb requested a review from StrikerRUS as a code owner December 3, 2021 05:47
@StrikerRUS StrikerRUS changed the title [R-package] fix --no-build-vignetttes option for build-cran-package.sh [R-package] fix --no-build-vignettes option for build-cran-package.sh Dec 3, 2021
@StrikerRUS StrikerRUS merged commit f54e32f into microsoft:master Dec 3, 2021
@jameslamb jameslamb deleted the fix/cran-package branch December 3, 2021 23:30
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants