-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] remove early_stopping_rounds
argument of train()
and cv()
functions
#4908
Conversation
10613cd
to
b133600
Compare
b133600
to
c7265f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Really happy to see these simplifications.
I believe this was the last one for the Python-package. 🎉 I can find only one
|
Excellent! And as a reminder, those were just added in #4685 and won't be removed until 4.1.x (#4685 (comment)) |
…on > 3.3.1 (#5206) The parameter evals_result is removed in the master of lightgbm: microsoft/LightGBM#4882. The parameter early_stopping_rounds is removed in the master of lightgbm: microsoft/LightGBM#4908. We should also remove this param in our test. This PR also fixed the sagemaker test failure. Signed-off-by: Liang Zhang <[email protected]>
* Add method to load model input example Signed-off-by: Matthieu Maitre <[email protected]> * Try fixing doc and lint failures Signed-off-by: Matthieu Maitre <[email protected]> * Remove param 'evals_result' 'early_stopping_rounds' in lightgbm version > 3.3.1 (#5206) The parameter evals_result is removed in the master of lightgbm: microsoft/LightGBM#4882. The parameter early_stopping_rounds is removed in the master of lightgbm: microsoft/LightGBM#4908. We should also remove this param in our test. This PR also fixed the sagemaker test failure. Signed-off-by: Liang Zhang <[email protected]> * Address PR feedback Signed-off-by: Matthieu Maitre <[email protected]> Co-authored-by: Liang Zhang <[email protected]>
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Refer to #4574.