Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] make record_evaluation callback pickleable #5107

Merged
merged 4 commits into from
Mar 30, 2022
Merged

[python] make record_evaluation callback pickleable #5107

merged 4 commits into from
Mar 30, 2022

Conversation

StrikerRUS
Copy link
Collaborator

Contributes to #5080.

@StrikerRUS StrikerRUS mentioned this pull request Mar 30, 2022
Closed
4 tasks
@StrikerRUS StrikerRUS marked this pull request as ready for review March 30, 2022 19:31
jameslamb
jameslamb approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thanks! And thanks very much for simplifying the "pickle then unpickle" code in tests, now that there are several cases of a similarly-structured test.

jmoralez
jmoralez approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@StrikerRUS StrikerRUS merged commit 60244e4 into master Mar 30, 2022
@StrikerRUS StrikerRUS deleted the record_eval_callback branch March 30, 2022 22:09
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
Closed
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmoralez jmoralez jmoralez approved these changes

@jameslamb jameslamb jameslamb approved these changes

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

@hzy46 hzy46 Awaiting requested review from hzy46

@tongwu-sh tongwu-sh Awaiting requested review from tongwu-sh

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StrikerRUS @jameslamb @jmoralez