[ci] run Appveyor checks on PRs targeting release/ branches #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
jmoralez
approved these changes
Oct 8, 2022
jameslamb
added a commit
that referenced
this pull request
Oct 9, 2022
jameslamb
added a commit
that referenced
this pull request
Oct 9, 2022
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5527.
Contributes to #5525 .
I was wrong in #5527 ...
.appveyor.ymlin this repo DOES need to be modified to tell Appveyor to build on pull requests that targetrelease/*branches.This PR proposes such a change.
See https://www.appveyor.com/docs/branches/ for docs on how Appveyor's preferred syntax expects such "match all branches following a pattern".
This change will help with the
v3.3.3release, and I think it should be kept even after that to make such time-sensitive hotfix types of releases a bit easier in the future.How I tested this
Pushed a similar change to #5525, and that led to Appveyor successfully building on that PR that targets branch
release/v3.3.2.