[ci] upgrade macOS_regular job to Python 3.9 (fixes #5569) #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoralez
approved these changes
Nov 3, 2022
|
🤩 Thanks as always for the quick review @jmoralez ! |
jameslamb
added a commit
that referenced
this pull request
Dec 6, 2022
jameslamb
added a commit
that referenced
this pull request
Dec 6, 2022
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes blocking issue #5569.
Proposes upgrading the
macOS_regularCI job from Python 3.7 to 3.9, to try to fix CI errors possibly related toconda-forgedropping support for Python 3.7.Is this a breaking change for producing release artifacts?
I don't think so. The only artifact build from this task is the shared library for macOS,
lib_lightgbm.dylib.LightGBM/.ci/test.sh
Lines 259 to 261 in d8a6b88
And that shouldn't be affected by Python version, as we don't produce a shared library that links into any Python stuff.