Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Release v3.3.4 #5619

Closed
wants to merge 18 commits into from
Closed

[DO NOT MERGE] Release v3.3.4 #5619

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
58bf894
prefer 'vsnprintf' to 'vsprintf' (#5561)
jameslamb Nov 21, 2022
3f407e6
update VERSION.txt to 3.3.4
jameslamb Dec 6, 2022
b2e51b0
Auto-update configure
GitHubActionsBot Dec 6, 2022
f71f8fd
use xcode 14.1 on macOS-latest
jameslamb Dec 6, 2022
076ef41
Merge branch 'release/v3.3.4' of github.com:microsoft/LightGBM into r…
jameslamb Dec 6, 2022
49a6f89
remove dask pin and use R 4.2.2 in CI
jameslamb Dec 6, 2022
c587223
fix R 4.2.2 builds
jameslamb Dec 6, 2022
17cecd1
empty commit
jameslamb Dec 6, 2022
caecafd
try pinning dependencies
jameslamb Dec 8, 2022
cb9962a
ceiling on dask too
jameslamb Dec 9, 2022
d721f4e
ceiling on scikit-learn
jameslamb Dec 14, 2022
940022c
try capping python version
jameslamb Dec 14, 2022
581a7fa
fix numpy constraint
jameslamb Dec 14, 2022
70aa002
more pinning to old versions
jameslamb Dec 14, 2022
a47d7c7
fix QEMU
jameslamb Dec 24, 2022
b95c865
looser scikit-learn pin to try to get QEMU builds working
jameslamb Dec 29, 2022
8431c38
remove pin on scikit-learn and skip all the load_boston() tests
jameslamb Dec 29, 2022
8d68f34
fix detection of QEMU in pinning dependencies
jameslamb Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: 3.3.3.{build}
version: 3.3.4.{build}

image: Visual Studio 2015
platform: x64
Expand Down
1 change: 1 addition & 0 deletions .ci/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ if [[ $OS_NAME == "macos" ]]; then
sudo xcode-select -s /Applications/Xcode_10.3.app/Contents/Developer || exit -1
fi
else # gcc
sudo xcode-select -s /Applications/Xcode_14.1.app/Contents/Developer || exit -1
Copy link
Collaborator Author

@jameslamb jameslamb Dec 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to pull in this change from #5580 for GitHub Actions and Azure CI jobs on macOS-latest to work

if [[ $TASK != "mpi" ]]; then
brew install gcc
fi
Expand Down
18 changes: 9 additions & 9 deletions R-package/configure
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
# Generated by GNU Autoconf 2.69 for lightgbm 3.3.3.
# Generated by GNU Autoconf 2.69 for lightgbm 3.3.4.
#
#
# Copyright (C) 1992-1996, 1998-2012 Free Software Foundation, Inc.
Expand Down Expand Up @@ -576,8 +576,8 @@ MAKEFLAGS=
# Identity of this package.
PACKAGE_NAME='lightgbm'
PACKAGE_TARNAME='lightgbm'
PACKAGE_VERSION='3.3.3'
PACKAGE_STRING='lightgbm 3.3.3'
PACKAGE_VERSION='3.3.4'
PACKAGE_STRING='lightgbm 3.3.4'
PACKAGE_BUGREPORT=''
PACKAGE_URL=''

Expand Down Expand Up @@ -1182,7 +1182,7 @@ if test "$ac_init_help" = "long"; then
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
\`configure' configures lightgbm 3.3.3 to adapt to many kinds of systems.
\`configure' configures lightgbm 3.3.4 to adapt to many kinds of systems.

Usage: $0 [OPTION]... [VAR=VALUE]...

Expand Down Expand Up @@ -1244,7 +1244,7 @@ fi

if test -n "$ac_init_help"; then
case $ac_init_help in
short | recursive ) echo "Configuration of lightgbm 3.3.3:";;
short | recursive ) echo "Configuration of lightgbm 3.3.4:";;
esac
cat <<\_ACEOF

Expand Down Expand Up @@ -1311,7 +1311,7 @@ fi
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
lightgbm configure 3.3.3
lightgbm configure 3.3.4
generated by GNU Autoconf 2.69

Copyright (C) 2012 Free Software Foundation, Inc.
Expand All @@ -1328,7 +1328,7 @@ cat >config.log <<_ACEOF
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.

It was created by lightgbm $as_me 3.3.3, which was
It was created by lightgbm $as_me 3.3.4, which was
generated by GNU Autoconf 2.69. Invocation command line was

$ $0 $@
Expand Down Expand Up @@ -2419,7 +2419,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
# report actual input values of CONFIG_FILES etc. instead of their
# values after options handling.
ac_log="
This file was extended by lightgbm $as_me 3.3.3, which was
This file was extended by lightgbm $as_me 3.3.4, which was
generated by GNU Autoconf 2.69. Invocation command line was

CONFIG_FILES = $CONFIG_FILES
Expand Down Expand Up @@ -2472,7 +2472,7 @@ _ACEOF
cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
ac_cs_version="\\
lightgbm config.status 3.3.3
lightgbm config.status 3.3.4
configured by $0, generated by GNU Autoconf 2.69,
with options \\"\$ac_cs_config\\"

Expand Down
2 changes: 1 addition & 1 deletion VERSION.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.3.3
3.3.4
7 changes: 4 additions & 3 deletions include/LightGBM/utils/log.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,13 @@ class Log {
}
static void Fatal(const char *format, ...) {
va_list val;
char str_buf[1024];
const size_t kBufSize = 1024;
char str_buf[kBufSize];
va_start(val, format);
#ifdef _MSC_VER
vsprintf_s(str_buf, format, val);
vsnprintf_s(str_buf, kBufSize, format, val);
#else
vsprintf(str_buf, format, val);
vsnprintf(str_buf, kBufSize, format, val);
#endif
va_end(val);

Expand Down