WIP: [DO NOT MERGE] Release v3.3.5

.appveyor.yml

@@ -1,4 +1,4 @@
-version: 3.3.4.{build}
+version: 3.3.5.{build}
 
 image: Visual Studio 2015
 platform: x64

.github/workflows/r_configure.yml

@@ -8,7 +8,7 @@ jobs:
   r-configure:
     name: r-configure
     timeout-minutes: 60
-    runs-on: 'ubuntuu-20.04'
+    runs-on: 'ubuntu-20.04'
     container: "ubuntu:20.04"
     steps:
       - name: Install essential software before checkout

.github/workflows/r_package.yml

@@ -235,6 +235,46 @@ jobs:
         with:
           fetch-depth: 5
           submodules: true
+      - name: update to clang 15
+        shell: bash
+        run: |
+          # remove clang stuff that comes installed in the image
+          apt-get autoremove -y --purge \
+              clang-* \
+              libclang-* \
+              libunwind-* \
+              llvm-*
+          #
+          # replace it all with clang-15
+          apt-get update -y
+          apt-get install --no-install-recommends -y \
+              gnupg \
+              lsb-release \
+              software-properties-common \
+              wget
+          #
+          wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add -
+          #
+          add-apt-repository "deb http://apt.llvm.org/bullseye/ llvm-toolchain-bullseye-15 main"
+          apt-get install -y --no-install-recommends \
+              clang-15 \
+              clangd-15 \
+              clang-format-15 \
+              clang-tidy-15 \
+              clang-tools-15 \
+              lldb-15 \
+              lld-15 \
+              llvm-15-dev \
+              llvm-15-tools \
+              libomp-15-dev \
+              libc++-15-dev \
+              libc++abi-15-dev \
+              libclang-common-15-dev \
+              libclang-15-dev \
+              libclang-cpp15-dev \
+              libunwind-15-dev
+          # overwrite everything in /usr/bin with the new v15 versions
+          cp --remove-destination /usr/lib/llvm-15/bin/* /usr/bin/
       - name: Install packages and run tests
         shell: bash
         run: |

R-package/configure

@@ -1,6 +1,6 @@
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for lightgbm 3.3.4.
+# Generated by GNU Autoconf 2.69 for lightgbm 3.3.5.
 #
 #
 # Copyright (C) 1992-1996, 1998-2012 Free Software Foundation, Inc.
@@ -576,8 +576,8 @@ MAKEFLAGS=
 # Identity of this package.
 PACKAGE_NAME='lightgbm'
 PACKAGE_TARNAME='lightgbm'
-PACKAGE_VERSION='3.3.4'
-PACKAGE_STRING='lightgbm 3.3.4'
+PACKAGE_VERSION='3.3.5'
+PACKAGE_STRING='lightgbm 3.3.5'
 PACKAGE_BUGREPORT=''
 PACKAGE_URL=''
 
@@ -1182,7 +1182,7 @@ if test "$ac_init_help" = "long"; then
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat <<_ACEOF
-\`configure' configures lightgbm 3.3.4 to adapt to many kinds of systems.
+\`configure' configures lightgbm 3.3.5 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1244,7 +1244,7 @@ fi
 
 if test -n "$ac_init_help"; then
   case $ac_init_help in
-     short | recursive ) echo "Configuration of lightgbm 3.3.4:";;
+     short | recursive ) echo "Configuration of lightgbm 3.3.5:";;
    esac
   cat <<\_ACEOF
 
@@ -1311,7 +1311,7 @@ fi
 test -n "$ac_init_help" && exit $ac_status
 if $ac_init_version; then
   cat <<\_ACEOF
-lightgbm configure 3.3.4
+lightgbm configure 3.3.5
 generated by GNU Autoconf 2.69
 
 Copyright (C) 2012 Free Software Foundation, Inc.
@@ -1328,7 +1328,7 @@ cat >config.log <<_ACEOF
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by lightgbm $as_me 3.3.4, which was
+It was created by lightgbm $as_me 3.3.5, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   $ $0 $@
@@ -2419,7 +2419,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
 # report actual input values of CONFIG_FILES etc. instead of their
 # values after options handling.
 ac_log="
-This file was extended by lightgbm $as_me 3.3.4, which was
+This file was extended by lightgbm $as_me 3.3.5, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   CONFIG_FILES    = $CONFIG_FILES
@@ -2472,7 +2472,7 @@ _ACEOF
 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
 ac_cs_version="\\
-lightgbm config.status 3.3.4
+lightgbm config.status 3.3.5
 configured by $0, generated by GNU Autoconf 2.69,
   with options \\"\$ac_cs_config\\"
 

R-package/cran-comments.md

@@ -1,9 +1,51 @@
 # CRAN Submission History
 
-## v3.3.2 - Submission 1 - (TBD)
+## v3.3.4 - Submission 1 - (December 15, 2022)
 
 ### CRAN response
 
+Accepted to CRAN
+
+### Maintainer Notes
+
+Submitted with the following comment:
+
+> This submission contains {lightgbm} 3.3.3.
+
+> Per CRAN's policies, I am submitting it on behalf of the project's maintainer (Yu Shi), with his permission.
+
+> This submission includes patches to address the following warnings observed on the fedora and debian CRAN checks.
+>
+> Compiled code should not call entry points which might terminate R nor write to stdout/stderr instead of to the console, nor use Fortran I/O nor system RNGs nor [v]sprintf.
+
+> Thank you very much for your time and consideration.
+
+## v3.3.3 - Submission 1 - (October 10, 2022)
+
+### CRAN response
+
+Accepted to CRAN
+
+### Maintainer Notes
+
+Submitted with the following comment:
+
+> This submission contains {lightgbm} 3.3.3.
+
+> Per CRAN's policies, I am submitting on it on behalf of the project's maintainer (Yu Shi), with his permission (https://github.com/microsoft/LightGBM/pull/5525).
+
+> This submission includes two patches:
+> * a change to testing to avoid a failed test related to non-ASCII strings on the `r-devel-linux-x86_64-debian-clang` check flavor (https://github.com/microsoft/LightGBM/pull/5526)
+> * modifications to allow compatibility with the RTools42 build toolchain (https://github.com/microsoft/LightGBM/pull/5503)
+
+> Thank you very much for your time and consideration.
+
+## v3.3.2 - Submission 1 - (January 7, 2022)
+
+### CRAN response
+
+Accepted to CRAN on January 14, 2022.
+
 ### Maintainer Notes
 
 In this submission, we uploaded a patch that CRAN stuff provided us via e-mail. The full text of the e-mail from CRAN:

VERSION.txt

@@ -1 +1 @@
-3.3.4
+3.3.5

src/io/json11.cpp

@@ -34,7 +34,6 @@ static const int max_depth = 200;
 using std::initializer_list;
 using std::make_shared;
 using std::map;
-using std::move;
 using std::string;
 using std::vector;
 
@@ -147,7 +146,7 @@ class Value : public JsonValue {
  protected:
   // Constructors
   explicit Value(const T &value) : m_value(value) {}
-  explicit Value(T &&value) : m_value(move(value)) {}
+  explicit Value(T &&value) : m_value(std::move(value)) {}
 
   // Get type tag
   Json::Type type() const override { return tag; }
@@ -204,7 +203,7 @@ class JsonString final : public Value<Json::STRING, string> {
 
  public:
   explicit JsonString(const string &value) : Value(value) {}
-  explicit JsonString(string &&value) : Value(move(value)) {}
+  explicit JsonString(string &&value) : Value(std::move(value)) {}
 };
 
 class JsonArray final : public Value<Json::ARRAY, Json::array> {
@@ -213,7 +212,7 @@ class JsonArray final : public Value<Json::ARRAY, Json::array> {
 
  public:
   explicit JsonArray(const Json::array &value) : Value(value) {}
-  explicit JsonArray(Json::array &&value) : Value(move(value)) {}
+  explicit JsonArray(Json::array &&value) : Value(std::move(value)) {}
 };
 
 class JsonObject final : public Value<Json::OBJECT, Json::object> {
@@ -222,7 +221,7 @@ class JsonObject final : public Value<Json::OBJECT, Json::object> {
 
  public:
   explicit JsonObject(const Json::object &value) : Value(value) {}
-  explicit JsonObject(Json::object &&value) : Value(move(value)) {}
+  explicit JsonObject(Json::object &&value) : Value(std::move(value)) {}
 };
 
 class JsonNull final : public Value<Json::NUL, NullStruct> {
@@ -265,15 +264,15 @@ Json::Json(double value) : m_ptr(make_shared<JsonDouble>(value)) {}
 Json::Json(int value) : m_ptr(make_shared<JsonInt>(value)) {}
 Json::Json(bool value) : m_ptr(value ? statics().t : statics().f) {}
 Json::Json(const string &value) : m_ptr(make_shared<JsonString>(value)) {}
-Json::Json(string &&value) : m_ptr(make_shared<JsonString>(move(value))) {}
+Json::Json(string &&value) : m_ptr(make_shared<JsonString>(std::move(value))) {}
 Json::Json(const char *value) : m_ptr(make_shared<JsonString>(value)) {}
 Json::Json(const Json::array &values) : m_ptr(make_shared<JsonArray>(values)) {}
 Json::Json(Json::array &&values)
-    : m_ptr(make_shared<JsonArray>(move(values))) {}
+    : m_ptr(make_shared<JsonArray>(std::move(values))) {}
 Json::Json(const Json::object &values)
     : m_ptr(make_shared<JsonObject>(values)) {}
 Json::Json(Json::object &&values)
-    : m_ptr(make_shared<JsonObject>(move(values))) {}
+    : m_ptr(make_shared<JsonObject>(std::move(values))) {}
 
 /* * * * * * * * * * * * * * * * * * * *
  * Accessors
@@ -378,7 +377,7 @@ struct JsonParser final {
    *
    * Mark this parse as failed.
    */
-  Json fail(string &&msg) { return fail(move(msg), Json()); }
+  Json fail(string &&msg) { return fail(std::move(msg), Json()); }
 
   template <typename T>
   T fail(string &&msg, const T err_ret) {