Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] increase valgrind timeout to 6 hours #5953

Merged
merged 5 commits into from
Jul 4, 2023
Merged

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Jun 30, 2023

Blocks #5952.

Notes for Reviewers

As described in #5414, this has to be merged to master to be tested, since the valgrind job's configuration is only sourced from master.

6 hours is the absolute maximum GitHub Actions allows: https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits.

So if this doesn't work, we'll have to come up with another strategy for running the valgrind tests faster (like maybe finding a source of Linux precompiled binaries for {lightgbm}'s dependencies), or will have to rely on running them somewhere else (even maybe just locally on a maintainer's laptop 😬 ).

@jameslamb jameslamb requested a review from StrikerRUS as a code owner June 30, 2023 15:30
@jameslamb jameslamb changed the title [ci] increase valgrind timeout to 5 hours [ci] increase valgrind timeout to 6 hours Jun 30, 2023
@jameslamb
Copy link
Collaborator Author

check-docs is failing with this error that seems to be occuring while rendering the sphinx docs to HTML

Warning, treated as error:
/home/runner/work/LightGBM/LightGBM/python-package/lightgbm/dask.py:docstring of lightgbm.dask.DaskLGBMClassifier:1:undefined label: 'metadata_routing'

(build link)

I see that on master too (build link).

Since that blocks merging, I'll try to fix it in this PR too. Moving this back to draft until that's fixed.

@jameslamb jameslamb marked this pull request as draft June 30, 2023 15:40
@jameslamb jameslamb changed the title [ci] increase valgrind timeout to 6 hours WIP: [ci] increase valgrind timeout to 6 hours Jun 30, 2023
@jameslamb jameslamb changed the title WIP: [ci] increase valgrind timeout to 6 hours WIP: [ci] increase valgrind timeout to 6 hours, fix docs generation Jul 2, 2023
@jameslamb jameslamb changed the title WIP: [ci] increase valgrind timeout to 6 hours, fix docs generation [ci] increase valgrind timeout to 6 hours, fix docs generation Jul 2, 2023
@jameslamb jameslamb marked this pull request as ready for review July 2, 2023 01:55
@jameslamb jameslamb changed the title [ci] increase valgrind timeout to 6 hours, fix docs generation [ci] increase valgrind timeout to 6 hours, fix docs generation (fixes #5954) Jul 2, 2023
@jameslamb jameslamb changed the title [ci] increase valgrind timeout to 6 hours, fix docs generation (fixes #5954) [ci] increase valgrind timeout to 6 hours Jul 4, 2023
docs/env.yml Outdated Show resolved Hide resolved
@jameslamb
Copy link
Collaborator Author

@guolinke @shiyu1994 could you please review this? So we can continue testing v4.0.0 on #5952.

@jameslamb
Copy link
Collaborator Author

thanks @jmoralez !

hopefully 6 hours is enough 🤞🏻

@jameslamb jameslamb merged commit 2b74e9f into master Jul 4, 2023
@jameslamb jameslamb deleted the valgrind-timeout branch July 4, 2023 15:05
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot removed the blocking label Oct 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants