-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] increase valgrind timeout to 6 hours #5953
Conversation
I see that on Since that blocks merging, I'll try to fix it in this PR too. Moving this back to draft until that's fixed. |
@guolinke @shiyu1994 could you please review this? So we can continue testing v4.0.0 on #5952. |
thanks @jmoralez ! hopefully 6 hours is enough 🤞🏻 |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Blocks #5952.
r-valgrind
CI job to 6 hours, to try to fix Release v4.0.0 #5952 (comment)Notes for Reviewers
As described in #5414, this has to be merged to
master
to be tested, since the valgrind job's configuration is only sourced frommaster
.6 hours is the absolute maximum GitHub Actions allows: https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits.
So if this doesn't work, we'll have to come up with another strategy for running the valgrind tests faster (like maybe finding a source of Linux precompiled binaries for
{lightgbm}
's dependencies), or will have to rely on running them somewhere else (even maybe just locally on a maintainer's laptop 😬 ).