[ci] prevent lock-threads from locking issues with label 'feature request' #6047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6037 reintroduced a bot for locking discussion on long-inactive closed PRs and issues, to encourage discussions to stay in highly-visible places.
This PR fixes two bugs in that configuration:
feature request
are not lockedText wrapping
What the bot currently produces:
What I want it to look like:
Notice that there isn't an unnecessary line break after the link to the issues page. That'll make the text look a bit better when screens are resized.
To learn how switching from
|
to>
in the configuration achieves that, see https://yaml-multiline.info/.feature request
labelAs described in #6037 (comment), the bot is locking some issues with label
feature request
, e.g. #3200 (comment).Looks to me like
lock-threads
requires that labels passed into itsexclude-any-issue-labels
configuration be double-quoted if they contain spaces.That's because that feature works by directly appending a
-label:
search body using GitHub's code search API (docs):https://github.com/dessant/lock-threads/blob/be8aa5be94131386884a6da4189effda9b14aa21/src/index.js#L143-L146
I tested this in the GitHub UI, and can see the effect.
https://github.com/microsoft/LightGBM/issues?q=is%3Aissue+is%3Aclosed+-label%3Afeature+request
With quoting around that label, the search matches the expected issues.
https://github.com/microsoft/LightGBM/issues?q=is%3Aissue+is%3Aclosed+-label%3A%22feature+request%22
Thanks to this comment from @alessbell for the hint: dessant/lock-threads#40 (comment).
Notes for Reviewers
I've manually unlocked all of the closed issues with label
feature request
that were incorrectly locked after merging #6037.