-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] fix mypy errors related to eval result tuples #6097
Conversation
cc @raubitsj @ayulockin I noticed tonight that this issue with the type hints was noticed almost 2 years ago in your development on
First... thanks for your work on that integration, in helping LightGBM's users get the most of their models. In the future, we'd really appreciate contributions here when you notice issues in LightGBM. Both code contributions and documenting problems at https://github.com/microsoft/LightGBM/issues are very helpful to the project. I'd be happy to help answer any questions you have about contributing, or to hear any critical feedback you have about ways we could improve the contribution process. |
Thanks for pointing out @jameslamb. It might have slipped out while rapidly developing the integration. Will make sure to open an issue if we spot any. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Contributes to #3756.
Contributes to #3867.
Resolves the following errors from
mypy
:These both came from an incorrect type hint on
lightgbm.callback.CallbackEnv.evaluation_result_list
, which failed to include the possibility of eval result tuples that included a 5th element for the across-folds standard deviation of metrics, as are calculated incv()
.