Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] ensure correct R version is used on GitHub Actions (fixes #5640) #6107

Merged
merged 6 commits into from
Sep 20, 2023
Merged

[ci] ensure correct R version is used on GitHub Actions (fixes #5640) #6107

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
35dfe17
[ci] ensure correct R version is used on GitHub Actions (fixes #5640)
jameslamb Sep 19, 2023
6aa9544
fix error message
jameslamb Sep 19, 2023
a139fb0
fix string interp
jameslamb Sep 19, 2023
d3c0a73
fix broken check
jameslamb Sep 20, 2023
857fa98
Merge branch 'master' into ci/r-version
jameslamb Sep 20, 2023
3190e79
fix log file
jameslamb Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .ci/test_r_package_windows.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,19 @@ if ($env:COMPILER -ne "MSVC") {
}
}

# Checking that the correct R version was used
if ($env:TOOLCHAIN -ne "MSVC") {
$checks = Select-String -Path "${LOG_FILE_NAME}" -Pattern "using R version $env:R_WINDOWS_VERSION"
$checks_cnt = $checks.Matches.length
} else {
$checks = Select-String -Path "${INSTALL_LOG_FILE_NAME}" -Pattern "R version passed into FindLibR.* $env:R_WINDOWS_VERSION"
$checks_cnt = $checks.Matches.length
}
if ($checks_cnt -eq 0) {
Write-Output "Wrong R version was found (expected '$env:R_WINDOWS_VERSION'). Check the build logs."
Check-Output $False
}

# Checking that we actually got the expected compiler. The R package has some logic
# to fail back to MinGW if MSVC fails, but for CI builds we need to check that the correct
# compiler was used.
Expand Down