Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow new files in include/LightGBM #6177

Merged
merged 1 commit into from
Nov 6, 2023
Merged

allow new files in include/LightGBM #6177

merged 1 commit into from
Nov 6, 2023

Conversation

jameslamb
Copy link
Collaborator

This fixes an unintended behavior in this project's git configuration.

The .gitignore rule intended to block inclusion of the LightGBM CLI (a binary file named lightgbm) also prevents including of any new files in include/LightGBM:

touch include/LightGBM/something.h
git add include/LightGBM/something.h
The following paths are ignored by one of your .gitignore files:
include/LightGBM
hint: Use -f if you really want to add them.
hint: Turn this message off by running
hint: "git config advice.addIgnoredFile false"

@borchero ran into this here: #6034 (comment)

This PR fixes that by adding a leading / to that rule. References explaining why that works:

@jameslamb jameslamb merged commit 72e8106 into master Nov 6, 2023
39 checks passed
@jameslamb jameslamb deleted the misc/gitignore branch November 6, 2023 16:00
david-cortes pushed a commit to david-cortes/LightGBM that referenced this pull request Nov 8, 2023
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants