WIP: [ci] [R-package] more closely mimic CRAN compiler configs in clang-devel jobs #6276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #6264.
After merging #6265, I thought more about this comment from @fabsig : #6265 (comment).
I think it's possible that differences in compiler flags could lead to different behavior and maybe a false negative on the CI jobs intended to reproduce the CRAN check.
CRAN's flags for the
clang18check are described here:I noticed some of those flags weren't showing up in logs. This adds them to get closer to CRAN's configuration and therefore improve our confidence that these CI checks passing means a new submission to CRAN will pass.