-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] restore aarch64 linux builds (fixes #6509) #6527
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
changed the title
WIP: [ci] restore aarch64 linux builds (fixes #6509)
[ci] restore aarch64 linux builds (fixes #6509)
Jul 8, 2024
jameslamb
requested review from
guolinke,
shiyu1994,
jmoralez and
borchero
as code owners
July 8, 2024 22:56
StrikerRUS
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Awesome research in #6509!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6509
follow-up to #6517
Proposes:
aarch64
Linux buildsscikit-learn
import earlier, to hopefully loadlibgomp.so
earlierscikit-build-core
to set the wheel platform tag, instead of doing it manually withmv
statementsNotes for Reviewers
What happened to the idea of running these builds in Docker on the
macos-14
runner?it isn't possible because running docker on those runners isn't possible (click me)
ref: #6509 (comment)
I was hoping to be able to use Docker on the M1 Mac runner to do aarch64 linux builds... those runners already have an arm64 CPU, so we'd be able to do builds and testing without emulation, which should be much faster.
Unfortunately, that did not work. As of this writing, that runner does not support nested virtualization, so it isn't possible to run
docker
on it. I tried withcolima
, thedocker
Homebrew cask, and podman.Some references:
So for now, this PR just restores the QEMU-based builds (using emulation).