Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] [cmake] simplify CMake-based R builds #6591

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

jameslamb
Copy link
Collaborator

Proposes some small simplifications to install.libs.R, the R script that runs cmake --build in CMake-based builds of the R package.

@jameslamb jameslamb changed the title WIP: [R-package] [cmake] simplify CMake-based R builds [R-package] [cmake] simplify CMake-based R builds Aug 6, 2024
@jameslamb jameslamb marked this pull request as ready for review August 6, 2024 03:17
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@StrikerRUS StrikerRUS merged commit 8843703 into master Aug 6, 2024
45 checks passed
@StrikerRUS StrikerRUS deleted the r/cmake-script branch August 6, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants