Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] prevent Python tests from leaving behind files #6626

Merged
merged 10 commits into from
Sep 3, 2024
Merged

[ci] prevent Python tests from leaving behind files #6626

Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
61033ac
graphivz Tree4.gv Tree4.gv.pdf are no longer persisted
vnherdeiro Aug 28, 2024
41c4051
DAsk test goes to temp folder, no test artefact
vnherdeiro Aug 28, 2024
df7f554
Update tests/python_package_test/test_plotting.py
vnherdeiro Aug 28, 2024
4edf45d
Update tests/python_package_test/test_plotting.py
vnherdeiro Aug 28, 2024
31f7c6a
Update tests/python_package_test/test_plotting.py
vnherdeiro Aug 28, 2024
c4ab1ff
adressing PR comment
vnherdeiro Aug 28, 2024
901cb82
Merge branch 'master' into remove_graphviz_test_artefacts
vnherdeiro Aug 30, 2024
484d4f8
fixed ruff linting
vnherdeiro Aug 30, 2024
5c4ef7a
Merge branch 'remove_dask_test_file' into remove_graphviz_test_artefacts
vnherdeiro Sep 2, 2024
5705597
Merge branch 'master' into remove_graphviz_test_artefacts
jameslamb Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/python_package_test/test_plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def test_plot_tree(breast_cancer_split):


@pytest.mark.skipif(not GRAPHVIZ_INSTALLED, reason="graphviz is not installed")
def test_create_tree_digraph(breast_cancer_split):
def test_create_tree_digraph(tmp_path, breast_cancer_split):
X_train, _, y_train, _ = breast_cancer_split

constraints = [-1, 1] * int(X_train.shape[1] / 2)
Expand All @@ -193,6 +193,7 @@ def test_create_tree_digraph(breast_cancer_split):
show_info=["split_gain", "internal_value", "internal_weight"],
name="Tree4",
node_attr={"color": "red"},
directory=tmp_path,
)
graph.render(view=False)
assert isinstance(graph, graphviz.Digraph)
Expand All @@ -213,7 +214,7 @@ def test_create_tree_digraph(breast_cancer_split):


@pytest.mark.skipif(not GRAPHVIZ_INSTALLED, reason="graphviz is not installed")
def test_tree_with_categories_below_max_category_values():
def test_tree_with_categories_below_max_category_values(tmp_path):
X_train, y_train = _categorical_data(2, 10)
params = {
"n_estimators": 10,
Expand All @@ -238,6 +239,7 @@ def test_tree_with_categories_below_max_category_values():
name="Tree4",
node_attr={"color": "red"},
max_category_values=10,
directory=tmp_path,
)
graph.render(view=False)
assert isinstance(graph, graphviz.Digraph)
Expand All @@ -257,7 +259,7 @@ def test_tree_with_categories_below_max_category_values():


@pytest.mark.skipif(not GRAPHVIZ_INSTALLED, reason="graphviz is not installed")
def test_tree_with_categories_above_max_category_values():
def test_tree_with_categories_above_max_category_values(tmp_path):
X_train, y_train = _categorical_data(20, 30)
params = {
"n_estimators": 10,
Expand All @@ -282,6 +284,7 @@ def test_tree_with_categories_above_max_category_values():
name="Tree4",
node_attr={"color": "red"},
max_category_values=4,
directory=tmp_path,
)
graph.render(view=False)
assert isinstance(graph, graphviz.Digraph)
Expand Down
Loading