Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] prevent Dask tests from leaving files behind #6627

Closed
wants to merge 3 commits into from
Closed

[ci] prevent Dask tests from leaving files behind #6627

wants to merge 3 commits into from

Conversation

vnherdeiro
Copy link
Contributor

@vnherdeiro vnherdeiro commented Aug 28, 2024 •
edited by jameslamb
Loading

Contributes to #6361

Prevents the following files from being left behind when the Python tests are run:

  • data_dask.csv

data_dask.csv goes to pytest temporary folder, gets teared down after test runs

@vnherdeiro vnherdeiro changed the title Dask test artefact goes to test temp folder, no test artefact #6361 Dask test artefact goes to test temp folder for tear down #6361 Aug 28, 2024
@vnherdeiro vnherdeiro changed the title Dask test artefact goes to test temp folder for tear down #6361 Dask test artefact goes to test temp folder for cleanup #6361 Aug 28, 2024
@jameslamb jameslamb changed the title Dask test artefact goes to test temp folder for cleanup #6361 [ci] prevent Dask tests from leaving files behind Aug 28, 2024
jameslamb
jameslamb requested changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one question about a change that surprised me.

tests/python_package_test/test_dask.py Outdated Show resolved Hide resolved
borchero
borchero approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@borchero borchero mentioned this pull request Sep 2, 2024
Merged
@borchero
Copy link
Collaborator

borchero commented Sep 2, 2024

Superseded by #6626.

@borchero borchero closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb requested changes

@borchero borchero borchero approved these changes

@guolinke guolinke Awaiting requested review from guolinke guolinke is a code owner

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

@jmoralez jmoralez Awaiting requested review from jmoralez jmoralez is a code owner

@StrikerRUS StrikerRUS Awaiting requested review from StrikerRUS StrikerRUS is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vnherdeiro @borchero @jameslamb