-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] fix linkchecker job #6757
[ci] fix linkchecker job #6757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works now, thanks a lot for quick fix!
As for the
Warning [http-rate-limited] Rate limited (Retry-After: None)
Result Valid: 429 Too Many Requests
errors, could you please try decreasing the maxrequestspersecond
for one host to 0.1
?
Line 2 in b33a12e
maxrequestspersecond=1 |
Refer to
- [ci][docs] set limit for max requests per second to one host in linkchecker #3785 (comment)
- https://linkchecker.github.io/linkchecker/man/linkcheckerrc.html#checking
Values less than 1 and at least 0.001 can be used.
It's now possible to use values less than 1.
Just pushed 5265786 with that change. I also put a floor on Thanks for the references and the suggestion! That saved me some effort figuring out how to get around those errors 😊 new test build: https://github.com/microsoft/LightGBM/actions/runs/12335867947 |
In case of successful run, we can try to increase Line 6 in a924516
I hope that linkchecker ensures that requests to one host are done from a single thread. |
Oh interesting, yeah hopefully that tool divides the hosts across threads instead of just dividing links. Pushed 4061211 setting |
It's still taking a very long time with I guess because the GitHub Actions Linux runners only have 4 vCPUS: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
LightGBM/R-package/R/lightgbm.R Lines 128 to 130 in 1090a93
Trying a build limiting to 4 threads: https://github.com/microsoft/LightGBM/actions/runs/12336463177 |
Heh, still 48 minutes with 4 threads... Seems that Anyway, we have successful cron job with less than 1 hour execution time that is run once a day. I believe it's totally fine and we shouldn't spend more time for the speedup! |
Yep I agree! I'll merge this. |
Fixes #6756
The relative path we pass to its config file needs to be updated (I think I broke this in #6497).
Notes for Reviewers
How I tested this
Manually triggered the link check workflow from this branch:
threads=10
: https://github.com/microsoft/LightGBM/actions/runs/12336243590threads=4
: https://github.com/microsoft/LightGBM/actions/runs/12336463177