Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block_to_split supports list str in CaptureSplitInfo pass #1609

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

xieofxie
Copy link
Contributor

@xieofxie xieofxie commented Feb 12, 2025

Describe your changes

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
    block_to_split supports list str in CaptureSplitInfo pass
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

@xieofxie
Copy link
Contributor Author

@jambayk I pushed to Olive and created a new pr. This test failed but I think it should not be so

test_bert[bert_ptq_cpu.json-local_system-joint-tpe]

could you help to take a look?

@jambayk
Copy link
Contributor

jambayk commented Feb 12, 2025

Thanks! Opened this PR to fix the flaky test #1612

@jambayk
Copy link
Contributor

jambayk commented Feb 13, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jambayk
jambayk previously approved these changes Feb 13, 2025
@xieofxie xieofxie merged commit f0d9d77 into main Feb 14, 2025
24 checks passed
@xieofxie xieofxie deleted the hualxie/CaptureSplitInfo branch February 14, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants