Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onnxruntime-genai from extras and pass dependencies #1620

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

jambayk
Copy link
Contributor

@jambayk jambayk commented Feb 14, 2025

Describe your changes

  • Removed onnxruntime-genai from extras and pass dependencies
  • There are multiple flavors of ort genai similar to ort. We cannot have onnxruntime-genai as an extra since it requires onnxruntime specifically which would override any existing installation of ort. It is better to install the desired flavor manually.
  • Model builder pass instead raises an import error with instructions to install the desired flavor of the package.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jambayk jambayk merged commit 9c513bf into main Feb 14, 2025
24 checks passed
@jambayk jambayk deleted the jambayk/extras branch February 14, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants