This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Adds visibility to failures in provisioning env #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kyleburnsdev
commented
Dec 2, 2022
kyleburnsdev
commented
- Writes errors in provisioning script to STDERR instead of STDOUT to enhance visibility
- Detects failure of SQL database import
- Final output message has been updated to provide a count of failed environments (if any)
kyleburnsdev
commented
Dec 6, 2022
| Write-Output "All resources are deployed. Enjoy the OpenHack!"; | ||
| } | ||
| else { | ||
| Write-Error "$failedEnvironments environments failed either provisioning or validation. Please check output for more details" |
There was a problem hiding this comment.
One thing that I considered here was to in the error path add exit 1 to provide an opportunity for automated execution to see the execution as unsuccessful and bubble to relevant reporting. I think that's an appropriate change, but couldn't be sure of ramifications to existing processes, so I didn't include it in this round.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.