Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NSwag JSON schema types and formats #2749

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Support NSwag JSON schema types and formats #2749

merged 3 commits into from
Dec 3, 2024

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam requested a review from a team as a code owner November 21, 2024 21:37
@bricelam
Copy link
Contributor Author

Yikes, not sure why GitHub made all the whitespace changes. Be sure to Hide whitespace

@bricelam
Copy link
Contributor Author

@microsoft-github-policy-service agree

@bricelam bricelam changed the title Support NSwag JSON schema integer formats Support NSwag JSON schema types and formats Nov 21, 2024
@MikeStall
Copy link
Contributor

Yikes, not sure why GitHub made all the whitespace changes. Be sure to Hide whitespace

Can you submit without the whitespace?
It's probably an auto-format feature in your editor.

The thing is the whitespace touches lots of lines, which can interfere with git blame and viewing history.

@bricelam bricelam force-pushed the patch-1 branch 2 times, most recently from 0011274 to 2902bd8 Compare December 2, 2024 00:00
LucGenetier
LucGenetier previously approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@LucGenetier LucGenetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LucGenetier
Copy link
Contributor

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LucGenetier
Copy link
Contributor

Looks like it doesn't compile
src\libraries\Microsoft.PowerFx.Connectors\OpenApiExtensions.cs(712,17): Error CS0152: The switch statement contains multiple cases with the label value '"file"'

@bricelam
Copy link
Contributor Author

bricelam commented Dec 2, 2024

Uh-oh, possibly a bad merge. Let me test that case again and update the code accordingly.

@bricelam
Copy link
Contributor Author

bricelam commented Dec 2, 2024

Updated. The file case has already been fixed since 1.2.0

@LucGenetier
Copy link
Contributor

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LucGenetier
Copy link
Contributor

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MikeStall MikeStall enabled auto-merge (squash) December 3, 2024 20:40
@MikeStall MikeStall merged commit a6fd1c6 into microsoft:main Dec 3, 2024
2 checks passed
@bricelam bricelam deleted the patch-1 branch December 4, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucGenetier LucGenetier LucGenetier approved these changes

Assignees

@LucGenetier LucGenetier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bricelam @MikeStall @LucGenetier