Skip to content

Enable rules for IDisposable and exceptions #1639

Enable rules for IDisposable and exceptions

Enable rules for IDisposable and exceptions #1639

Triggered via pull request April 22, 2024 16:36
Status Success
Total duration 5m 14s
Artifacts

CI.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
build (windows-latest): samples/MSAppGenerator/AppGeneratorFactory.cs#L17
Method .ctor passes '_controlFactory' as the paramName argument to a ArgumentNullException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
build (windows-latest): samples/MSAppGenerator/ExampleGenerator.cs#L107
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'ExampleGenerator.GenerateApp(string, int, IList<string>)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build (windows-latest): samples/MSAppGenerator/AppCreator.cs#L15
Change return type of method 'ConfigureServiceProvider' from 'System.IServiceProvider' to 'Microsoft.Extensions.DependencyInjection.ServiceProvider' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
build (windows-latest): samples/MSAppGenerator/InteractiveGenerator.cs#L38
In member App InteractiveGenerator.GenerateApp(string filePath, int numScreens, IList<string>? controls), change parameter name filePath to appName in order to match the identifier as it has been declared in App IAppGenerator.GenerateApp(string appName, int numScreens = 1, IList<string>? controls = null) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
build (windows-latest): samples/MSAppGenerator/InteractiveGenerator.cs#L47
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
build (windows-latest): samples/MSAppGenerator/InteractiveGenerator.cs#L56
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
build (windows-latest): samples/MSAppGenerator/InteractiveGenerator.cs#L66
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
build (windows-latest): samples/MSAppGenerator/InteractiveGenerator.cs#L73
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
build (windows-latest): samples/MSAppGenerator/InteractiveGenerator.cs#L77
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
build (windows-latest): samples/MSAppGenerator/InteractiveGenerator.cs#L47
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'InteractiveGenerator.GenerateApp(string, int, IList<string>)' with a call to 'string.ToLower(CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)